Added test environment for mssql #4282

kolaente · 2018-06-20T11:21:56Z

This pr adds a test step in drone to run tests with mssql db.

Even if you dont like Microsoft (like me), IMHO we should at least have tests for mssql dbs or not support it at all.

lafriks · 2018-06-20T11:33:08Z

.drone.yml

@@ -360,7 +360,7 @@ services:
    image: microsoft/mssql-server-linux:latest
    environment:
      - ACCEPT_EULA=Y
-      - SA_PASSWORD=M$wantsaSecurePassword
+      - SA_PASSWORD=M$wantsaSecurePassword1


I think you need to escape $ character otherwise it tries to connect with password MwantsaSecurePassword1

but maybe not it this file but in app.ini

Thanks for pointing that out, I thinks thats the issue.

lafriks · 2018-06-20T13:27:54Z

Database is not created so gitea is not able to connect:
error: mssql: Cannot open database "testgitea" that was requested by the login. Using the user default database "master" instead.

kolaente · 2018-06-20T14:26:23Z

@lafriks oh ok. Drone shows a different error message though... But I'll try with your recommondation.

kolaente · 2018-06-20T14:40:05Z

Now I get that weired error:

Failed to initialize ORM engine: sync database struct error: Unknown colType SYSNAME for MSreplication_options - optname

Is that an issue with xorm, the test I added, or Gitea?

\cc @lunny looks like a xorm issue.

lafriks · 2018-06-20T19:04:21Z

@kolaente Gitea does not create database so docker service needs to do it.

lunny · 2018-06-21T00:49:44Z

@kolaente I will investigate it. And as @lafriks said, you have to create database manually.

lunny · 2018-07-04T13:31:49Z

@kolaente you have to add some SQL to create the database at first.

techknowlogick · 2018-07-05T04:09:15Z

.drone.yml

@@ -172,6 +172,20 @@ pipeline:
    when:
      event: [ push, tag, pull_request ]

+  test-mssql:


Edit: I was being lazy, pay attention to @JonasFranzDEV as his solution is better than mine.
~~before the test steps (look at group test) you could have a step that creates the DB like:~~

mssql-create-db: image: microsoft/mssql-tools commands: - sqlcmd -S mssql -U sa -P MwantsaSecurePassword1 -Q "CREATE DATABASE master" when: event: [ push, tag, pull_request ]

~~I haven't tested the above (or indentation) but something like it should work~~

The better option might be to create the database in code like we do for pgsql and mysql:
https://github.com/go-gitea/gitea/blob/master/integrations/integration_test.go#L110

I've implemented it and the test works now

Signed-off-by: Jonas Franz <info@jonasfranz.software>

jonasfranz

The test environment works but the test fails for other reasons.

chdxD1 · 2018-12-11T14:02:13Z

@lunny Thanks for the pull request (this is also an issue but not the underlying one) go-xorm/xorm#1173
Tested this locally and all tests seem to be OK.

lunny · 2018-12-11T14:19:07Z

@chdxD1 thanks, merged xorm's PR. But we still need a PR to update xorm, maybe this PR? @kolaente

kolaente · 2018-12-11T15:12:23Z

@lunny I'll update it

kolaente · 2018-12-11T15:32:41Z

Now the build fails, does anyone know if xorm changed significant amounts of code so our code is invalid?

chdxD1 · 2018-12-11T16:36:03Z

@kolaente Could you please run a dep ensure locally and remove the string from the interface https://github.com/kolaente/gitea/blob/master/models/models.go#L39

kolaente · 2018-12-11T20:26:58Z

@chdxD1 Still fails, but because apparantly models/repo_watch.go:34 still uses exec
@lunny Is there a reason this used e.Exec instead of x.Exec? x is available in that context.

models/models.go

kolaente · 2018-12-11T20:29:58Z

Build should work now!

chdxD1 · 2018-12-11T20:30:48Z

@kolaente Despite repo_watch using e.Exec: This is the relevant change from xorm (for reviewers): go-xorm/xorm@4ce90f9
The first parameter is beeing checked for type string (so all calls to the Exec function will still work)

kolaente · 2018-12-11T20:34:14Z

@chdxD1 makes sense, I just thought it had beed removed in favour of x.SQL.

codecov-io · 2018-12-11T20:40:32Z

Codecov Report

Merging #4282 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #4282      +/-   ##
==========================================
- Coverage   37.62%   37.59%   -0.04%     
==========================================
  Files         319      319              
  Lines       46949    46949              
==========================================
- Hits        17666    17651      -15     
- Misses      26769    26791      +22     
+ Partials     2514     2507       -7

Impacted Files	Coverage Δ
models/models.go	`54.54% <0%> (ø)`	⬆️
modules/log/file.go	`42.73% <0%> (-24.79%)`	⬇️
routers/repo/view.go	`46.01% <0%> (+1.22%)`	⬆️
models/repo_list.go	`64.55% <0%> (+1.26%)`	⬆️
models/repo_indexer.go	`47.88% <0%> (+3.38%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1f3685...96f7f86. Read the comment docs.

kolaente · 2018-12-11T20:41:51Z

CI passes! 🎉 🎉 🎉 🎉 🎉 🎉

lafriks · 2018-12-11T21:21:50Z

@lunny need your approval

lunny · 2018-12-12T01:01:58Z

Thanks all of you!!!

kolaente added 3 commits June 20, 2018 13:01

Added test environment for m$sql

6570d21

Added template for test environment for m$sql

d365cd6

Fix password

2aa2f19

lafriks reviewed Jun 20, 2018

View reviewed changes

bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 20, 2018

kolaente added 2 commits June 20, 2018 14:30

Fix password (again)

38e8b9c

Fix password (again again)

6e3e458

lafriks added the type/testing label Jun 20, 2018

Fix db

f03fc16

kolaente added 4 commits June 20, 2018 16:30

Ci trigger (Looking at you drone....)

002b300

Ci trigger (Looking at you drone....)

fa731e2

Ci trigger (Looking at you drone....)

8b2e67e

Ci trigger (Looking at you drone....)

f5069eb

lunny added this to the 1.6.0 milestone Jul 4, 2018

lunny mentioned this pull request Jul 4, 2018

Error on startup 1.5 #4360

Closed

7 tasks

techknowlogick reviewed Jul 5, 2018

View reviewed changes

jonasfranz mentioned this pull request Jul 5, 2018

Gitea interface unavailable after deleting member of Org "Owners" team #4362

Closed

7 tasks

jonasfranz added 4 commits July 5, 2018 16:55

Create master database for mssql integration tests

3fc4bb3

Signed-off-by: Jonas Franz <info@jonasfranz.software>

Merge remote-tracking branch 'upstream/master' into mssql-test

6ebc478

Create database only if master do not exist

1c7c44f

Signed-off-by: Jonas Franz <info@jonasfranz.software>

Fix mssql integration tests by using custom database "gitea"

729a512

Signed-off-by: Jonas Franz <info@jonasfranz.software>

jonasfranz approved these changes Jul 5, 2018

View reviewed changes

bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 5, 2018

Merge branch 'master' into mssql-test

46da16e

chdxD1 mentioned this pull request Dec 11, 2018

Implementing elseif for conversion of Default go-xorm/xorm#1173

Merged

lunny closed this in go-xorm/xorm#1173 Dec 11, 2018

lunny reopened this Dec 11, 2018

bump xorm

b2196d8

updated xorm

d6ad629

Merge branch 'master' into mssql-test

1a27388

chdxD1 reviewed Dec 11, 2018

View reviewed changes

models/models.go Show resolved Hide resolved

Fixed build

6f5200c

techknowlogick removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Dec 11, 2018

lafriks approved these changes Dec 11, 2018

View reviewed changes

sapk approved these changes Dec 11, 2018

View reviewed changes

Merge branch 'master' into mssql-test

96f7f86

lunny approved these changes Dec 12, 2018

View reviewed changes

lunny merged commit 6db7dbd into go-gitea:master Dec 12, 2018

kolaente deleted the mssql-test branch December 12, 2018 09:36

go-gitea locked and limited conversation to collaborators Nov 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added test environment for mssql #4282

Added test environment for mssql #4282

kolaente commented Jun 20, 2018

lafriks Jun 20, 2018

lafriks Jun 20, 2018

kolaente Jun 20, 2018

lafriks commented Jun 20, 2018

kolaente commented Jun 20, 2018

kolaente commented Jun 20, 2018 •

edited

lafriks commented Jun 20, 2018

lunny commented Jun 21, 2018

lunny commented Jul 4, 2018

techknowlogick Jul 5, 2018 •

edited

jonasfranz Jul 5, 2018

jonasfranz Jul 5, 2018

jonasfranz left a comment

chdxD1 commented Dec 11, 2018

lunny commented Dec 11, 2018 •

edited

kolaente commented Dec 11, 2018

kolaente commented Dec 11, 2018

chdxD1 commented Dec 11, 2018

kolaente commented Dec 11, 2018

kolaente commented Dec 11, 2018

chdxD1 commented Dec 11, 2018

kolaente commented Dec 11, 2018

codecov-io commented Dec 11, 2018 •

edited

kolaente commented Dec 11, 2018

lafriks commented Dec 11, 2018

lunny commented Dec 12, 2018

Added test environment for mssql #4282

Added test environment for mssql #4282

Conversation

kolaente commented Jun 20, 2018

lafriks Jun 20, 2018

Choose a reason for hiding this comment

lafriks Jun 20, 2018

Choose a reason for hiding this comment

kolaente Jun 20, 2018

Choose a reason for hiding this comment

lafriks commented Jun 20, 2018

kolaente commented Jun 20, 2018

kolaente commented Jun 20, 2018 • edited

lafriks commented Jun 20, 2018

lunny commented Jun 21, 2018

lunny commented Jul 4, 2018

techknowlogick Jul 5, 2018 • edited

Choose a reason for hiding this comment

jonasfranz Jul 5, 2018

Choose a reason for hiding this comment

jonasfranz Jul 5, 2018

Choose a reason for hiding this comment

jonasfranz left a comment

Choose a reason for hiding this comment

chdxD1 commented Dec 11, 2018

lunny commented Dec 11, 2018 • edited

kolaente commented Dec 11, 2018

kolaente commented Dec 11, 2018

chdxD1 commented Dec 11, 2018

kolaente commented Dec 11, 2018

kolaente commented Dec 11, 2018

chdxD1 commented Dec 11, 2018

kolaente commented Dec 11, 2018

codecov-io commented Dec 11, 2018 • edited

Codecov Report

kolaente commented Dec 11, 2018

lafriks commented Dec 11, 2018

lunny commented Dec 12, 2018

kolaente commented Jun 20, 2018 •

edited

techknowlogick Jul 5, 2018 •

edited

lunny commented Dec 11, 2018 •

edited

codecov-io commented Dec 11, 2018 •

edited