Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive design fixes #4508

Merged
merged 5 commits into from
Jul 26, 2018
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public/css/index.css

Large diffs are not rendered by default.

13 changes: 12 additions & 1 deletion public/less/_dashboard.less
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,13 @@
top: 7px;
left: 90%;
width: 15%;

@media only screen and (max-width: 768px) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacing seems to be off

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, apparantly my editor was set to use tabs instead of spaces as the rest of the file.

top: 10px;
left: auto;
width: auto;
right: 13px;
}
}
}

Expand All @@ -40,12 +47,16 @@
right: 0!important;
left: auto!important;
}

@media only screen and (max-width: 768px) {
width: 100%;
}
}
.right.stackable.menu > .item.active {
color: #d9453d;
}
}

/* Accomodate for Semantic's 1px hacks on .attached elements */
.dashboard-repos {
margin: 0 1px;
Expand Down
45 changes: 40 additions & 5 deletions public/less/_form.less
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@
.user.reset.password,
.user.signin,
.user.signup {
@input-padding: 200px!important;
@input-padding: 200px;
#create-page-form;
form {
width: 700px!important;
Expand All @@ -111,7 +111,13 @@
text-align: center;
}
.inline.field > label {
width: @input-padding;
width: @input-padding;
}

.inline.field > label, input {
@media only screen and (max-width: 768px) {
width: 100% !important;
}
}
}
}
Expand All @@ -137,19 +143,35 @@
padding-left: 0 !important;
text-align: center;
}

@media only screen and (max-width: 768px) {
label, input, .selection.dropdown {
width: 100% !important;
}

.field button, .field a{
margin-bottom: 1em;
width: 100%;
}
}
}
}

&.new.repo {
.ui.form {
.selection.dropdown:not(.owner) {
width: 50%!important;
}
@media only screen and (min-width: 768px) {
#auto-init {
margin-left: @create-page-form-input-padding+15px;
}
}

.selection.dropdown:not(.owner) {
width: 50%!important;

@media only screen and (max-width: 768px) {
width: 100% !important;
}
}
}
}
}
Expand All @@ -175,3 +197,16 @@
font-family: monospace;
}
}

.new.org .ui.form {
@media only screen and (max-width: 768px) {
.field button, .field a{
margin-bottom: 1em;
width: 100%;
}

.field input {
width: 100% !important;
}
}
}
13 changes: 13 additions & 0 deletions public/less/_home.less
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,16 @@
padding-top: 15px;
padding-bottom: @footer-margin * 2;
}

footer {
@media only screen and (max-width: 880px) {
text-align: center;
}

.ui.container .left, .ui.container .right {
@media only screen and (max-width: 880px) {
display: inline;
float: none;
}
}
}
31 changes: 31 additions & 0 deletions public/less/_repository.less
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,14 @@
#clone-panel {
width: 350px;

@media only screen and (max-width: 768px) {
width: 100%;
}

input {
border-radius: 0;
padding: 5px 10px;
width: 50%;
}

.clone.button {
Expand Down Expand Up @@ -220,6 +225,12 @@
padding: 8px 10px;
font-weight: normal;
}

.ui.tiny.blue.buttons {
@media only screen and (max-width: 768px) {
width: 100%;
}
}
}

#repo-files-table {
Expand Down Expand Up @@ -1229,6 +1240,20 @@
.prerelease.field {
margin-bottom: 0;
}

.field {
button, input {
@media only screen and (max-width: 438px) {
width: 100%;
}
}

button {
@media only screen and (max-width: 768px) {
margin-bottom: 1em;
}
}
}
}

&.forks {
Expand Down Expand Up @@ -1756,3 +1781,9 @@ tbody.commit-list {
#repo-topic {
margin-top: 5px;
}

.new-dependency-drop-list {
@media only screen and (max-width: 768px) {
width: 100%;
}
}
16 changes: 16 additions & 0 deletions public/less/_user.less
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,22 @@
}
}
}

#profile-avatar {
@media only screen and (max-width: 768px) {
height: 250px;
overflow: hidden;

img {
max-height: 768px;
max-width: 768px;
}
}
}

@media only screen and (max-width: 768px) {
width: 100%;
}
}

.ui.repository.list {
Expand Down
2 changes: 1 addition & 1 deletion templates/repo/release/new.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
{{end}}
</h2>
{{template "base/alert" .}}
<form class="ui form grid" action="{{.Link}}" method="post">
<form class="ui form stackable grid" action="{{.Link}}" method="post">
{{.CsrfTokenHtml}}
<div class="ui seven wide column target">
<div class="inline field {{if .Err_TagName}}error{{end}}">
Expand Down