Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add a benchmark for pull merging #4908

Closed
wants to merge 2 commits into from

Conversation

typeless
Copy link
Contributor

This is going to to be used for measuring the speed improvement of the pull merging code.

@codecov-io
Copy link

codecov-io commented Sep 11, 2018

Codecov Report

Merging #4908 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4908      +/-   ##
==========================================
- Coverage   37.56%   37.55%   -0.01%     
==========================================
  Files         321      321              
  Lines       47206    47206              
==========================================
- Hits        17732    17729       -3     
+ Misses      26933    26931       -2     
- Partials     2541     2546       +5
Impacted Files Coverage Δ
models/repo_indexer.go 44.49% <0%> (-3.82%) ⬇️
routers/repo/view.go 46.01% <0%> (+1.22%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a02a78...08fcd16. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 11, 2018
@typeless typeless changed the title Add a benchmark for pull merging [WIP] Add a benchmark for pull merging Sep 12, 2018
@lafriks lafriks added the pr/wip This PR is not ready for review label Sep 12, 2018
@jonasfranz jonasfranz added this to the 1.7.0 milestone Sep 18, 2018
@techknowlogick techknowlogick modified the milestones: 1.7.0, 1.8.0 Dec 19, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 22, 2018
@lunny
Copy link
Member

lunny commented Dec 23, 2018

@typeless is this ready to review?

@typeless
Copy link
Contributor Author

@lunny The repo tested in this PR is not big enough to confirm the effectiveness of #4921. I was considering what you suggested the other day using a Docker container for the prepared repo. But I have no a clear roadmap on how to do it (adding sane test fixtures to emulate a ready-for-merging-PRs repo is too hard).

@techknowlogick techknowlogick modified the milestones: 1.8.0, 1.9.0 Feb 19, 2019
@typeless typeless closed this Mar 26, 2019
@lunny
Copy link
Member

lunny commented Mar 26, 2019

@typeless why close this?

@typeless
Copy link
Contributor Author

@lunny I think this PR is doing it the wrong way. It uses migrate to download a big (but not big enough) repo for benchmarking, which is very time-consuming. The ideal approach would be to prepare a test fixture which emulates the state of a ready-to-merge PR and probably a docker image containing a large repo as you suggested before.

@typeless typeless deleted the bench-merge branch April 3, 2019 05:01
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. pr/wip This PR is not ready for review type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants