Disable HTTP cloning

[thibaultmeyer]

Relative to #2583, this Pull Request allow administrator to disable any Git interactions by HTTP protocol.

[repository]
DISABLE_HTTP_GIT = true

[codecov-io]

Current coverage is 2.18% (diff: 100%)

Merging #50 into master will not change coverage

@@            master       #50   diff @@
========================================
  Files           31        31          
  Lines         7508      7508          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           164       164          
  Misses        7327      7327          
  Partials        17        17          

Powered by Codecov. Last update 42a744d...e54dec7

[tboerger]

the idea behind this enhancement is to deny HTTP protocol (regardless it was used with or without secure layer). So if you set DISABLE_HTTP_GIT= true in your app.ini file, you will be only able to use Git by SSH protocol (very useful on local /intranet usage).

I know, but since you are touching the code anyway you can also fix that broken part :)

[thibaultmeyer]

I don't see what is broken ? Their are no extra check needed. the variable $.CloneLink.HTTPS contain the HTTP version or the HTTPS depending of what is configured on app.ini

[tboerger]

I don't see what is broken ? Their are no extra check needed. the variable $.CloneLink.HTTPS contain the HTTP version or the HTTPS depending of what is configured on app.ini

Ok, if that is the case I'm fine with it. I have not checked that case.

[tboerger]

LGTM

[DblK]

Just a rebase and squash commits and I will approuve this one.

[thibaultmeyer]

You could choose "Rebase and Merge" during the merge process : https://github.com/blog/2243-rebase-and-merge-pull-requests

[tboerger]

This is something I don't want to do. Just rebase the code with latest master, push it with --force and it gets merged.

[jhasse]

I'm curious: Why would I want to do this?

[strk]

LGTM