Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor notification for indexer #5111

Merged
merged 3 commits into from Jan 17, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 19, 2018

extract from #4001

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Oct 19, 2018
@lunny lunny added this to the 1.7.0 milestone Oct 19, 2018
@codecov-io
Copy link

codecov-io commented Oct 19, 2018

Codecov Report

Merging #5111 into master will increase coverage by 0.02%.
The diff coverage is 70.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5111      +/-   ##
==========================================
+ Coverage   37.73%   37.76%   +0.02%     
==========================================
  Files         325      326       +1     
  Lines       47760    47779      +19     
==========================================
+ Hits        18022    18043      +21     
+ Misses      27143    27142       -1     
+ Partials     2595     2594       -1
Impacted Files Coverage Δ
models/issue_comment.go 46.18% <ø> (-0.49%) ⬇️
models/issue.go 47.59% <ø> (-0.05%) ⬇️
models/pull.go 50.65% <ø> (-0.1%) ⬇️
routers/repo/issue.go 36.68% <0%> (-0.14%) ⬇️
models/issue_indexer.go 57.64% <100%> (-5.58%) ⬇️
routers/api/v1/repo/issue_comment.go 56.79% <100%> (+0.54%) ⬆️
modules/notification/notification.go 38.46% <100%> (+9.57%) ⬆️
modules/notification/indexer/indexer.go 75% <75%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 477a80f...15aeacd. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 19, 2018
@techknowlogick techknowlogick modified the milestones: 1.7.0, 1.8.0 Dec 19, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 17, 2019
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 17, 2019
@lunny lunny merged commit 82e08a3 into go-gitea:master Jan 17, 2019
@lunny lunny deleted the lunny/notification_indexer branch January 17, 2019 14:23
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants