Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add secret to all webhook's payload where it has been missing #5208

Merged
merged 4 commits into from
Oct 30, 2018
Merged

fix: Add secret to all webhook's payload where it has been missing #5208

merged 4 commits into from
Oct 30, 2018

Conversation

HoffmannP
Copy link
Contributor

  • Updated dependency manager via dep ensure -update code.gitea.io/sdk
  • Gopkg.toml was not changed as sdk version is set to "master"
  • affects webhooks for: Delete, Fork, IssueComment, Release
  • also contains changes from Add deploy key changes go-sdk#125 and hence a swagger update

Signed-off-by: Berengar W. Lehr Berengar.Lehr@kompetenztest.de
Resolves: #4732, #5173

* Updated dependency manager via `dep ensure -update code.gitea.io/sdk`
* Gopkg.toml was not changed as sdk version is set to "master"
* affects webhooks for: Delete, Fork, IssueComment, Release
* also contains changes from go-gitea/go-sdk#125 and hence a swagger update

Signed-off-by: Berengar W. Lehr <Berengar.Lehr@kompetenztest.de>
Resolves: #4732, #5173
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 28, 2018
@lunny lunny added modifies/api This PR adds API routes or modifies them type/bug labels Oct 30, 2018
@lunny lunny added this to the 1.7.0 milestone Oct 30, 2018
@lunny
Copy link
Member

lunny commented Oct 30, 2018

But some changes are unrelated i.e. archived bool

@HoffmannP
Copy link
Contributor Author

@lunny this is the backport/1.6 for #5199. It contains other, unrelated changes gitea/go-sdk#125 by another party that were not merged until then.

@lafriks lafriks modified the milestones: 1.7.0, 1.6.0 Oct 30, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 30, 2018
@HoffmannP
Copy link
Contributor Author

@lafriks why did you remove the backport/1.6 label? Is it a "it's a backport" or a "should be a backport" label?

@lunny
Copy link
Member

lunny commented Oct 30, 2018

@HoffmannP just found I made a wrong label. backport/1.6 means should be backport to release 1.6

@lafriks lafriks merged commit e28801f into go-gitea:release/v1.6 Oct 30, 2018
@lafriks
Copy link
Member

lafriks commented Oct 30, 2018

@HoffmannP this label should be added to PRs to master branch that needs to be backported to release/1.x branches

@HoffmannP
Copy link
Contributor Author

@lafriks thank you for the clear up. I'm felling like I'm getting there

@HoffmannP HoffmannP deleted the release/v1.6 branch October 30, 2018 16:08
@lafriks lafriks added the type/changelog Adds the changelog for a new Gitea version label Nov 10, 2018
@AuspeXeu
Copy link

AuspeXeu commented Nov 12, 2018

I just tested the latest version 1.6.0-rc2 and it seems like this issue is still not resolved. Now, if I trigger a test delivery for a custom event of the type release, no request is queued whatsoever. Before (1.5.3) it simply didn't contain the secret.

@HoffmannP
Copy link
Contributor Author

@AuspeXeu Could you open an issue? Do you get any error log?

@AuspeXeu
Copy link

@HoffmannP I added it to my initial issue #5173 I do not get any error logged unfortunately.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants