Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sqlite lock #5210

Merged
merged 2 commits into from
Oct 30, 2018
Merged

Fix sqlite lock #5210

merged 2 commits into from
Oct 30, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 29, 2018

No description provided.

@lunny lunny added this to the 1.7.0 milestone Oct 29, 2018
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 29, 2018
@codecov-io
Copy link

codecov-io commented Oct 29, 2018 •
edited
Loading

Codecov Report

Merging #5210 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5210      +/-   ##
=========================================
+ Coverage   37.49%   37.5%   +<.01%     
=========================================
  Files         309     309              
  Lines       45827   45827              
=========================================
+ Hits        17185   17188       +3     
+ Misses      26180   26178       -2     
+ Partials     2462    2461       -1
Impacted Files Coverage Δ
models/repo.go 43.57% <100%> (ø) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ceae07...eb790a4. Read the comment docs.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 30, 2018
@lunny lunny merged commit 735b12e into go-gitea:master Oct 30, 2018
lunny added a commit to lunny/gitea that referenced this pull request Oct 30, 2018
@lunny
fix sqlite lock (go-gitea#5210)
3cf9dc2
@lunny lunny deleted the lunny/fix_lock3 branch October 30, 2018 01:22
@lunny lunny mentioned this pull request Oct 30, 2018
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Oct 30, 2018
lunny added a commit that referenced this pull request Oct 30, 2018
@lunny
fix sqlite lock (#5210) (#5223)
478ba7f
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@sapk sapk sapk approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lunny @codecov-io @techknowlogick @sapk @bkcsoft