Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test environment for Mysql8 #5234

Merged
merged 14 commits into from Mar 17, 2019

Conversation

@lunny
Copy link
Member

lunny commented Oct 31, 2018

No description provided.

@lunny lunny added the kind/testing label Oct 31, 2018

@lunny lunny added this to the 1.7.0 milestone Oct 31, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 31, 2018

Codecov Report

Merging #5234 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5234   +/-   ##
=======================================
  Coverage   38.87%   38.87%           
=======================================
  Files         363      363           
  Lines       51210    51210           
=======================================
  Hits        19908    19908           
  Misses      28434    28434           
  Partials     2868     2868

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3ad5eb...25e698e. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 label Oct 31, 2018

@jonasfranz

This comment has been minimized.

Copy link
Member

jonasfranz commented Nov 1, 2018

drone fails

@lunny

This comment has been minimized.

Copy link
Member Author

lunny commented Nov 2, 2018

I think the CI failed because both container listen on :3306

@techknowlogick

This comment has been minimized.

Copy link
Member

techknowlogick commented Nov 4, 2018

@lunny because the server is a docker container the IP will be different so it is ok if port is the same

Show resolved Hide resolved integrations/mysql8.ini.tmpl Outdated
Show resolved Hide resolved integrations/mysql8.ini.tmpl Outdated
Show resolved Hide resolved integrations/mysql8.ini.tmpl Outdated
Show resolved Hide resolved integrations/mysql8.ini.tmpl Outdated
Show resolved Hide resolved integrations/mysql8.ini.tmpl Outdated
Show resolved Hide resolved integrations/mysql8.ini.tmpl Outdated

lunny added some commits Oct 31, 2018

@lunny lunny force-pushed the lunny:lunny/mysql8_test branch from d460b49 to 2b97c85 Nov 7, 2018

@techknowlogick techknowlogick modified the milestones: 1.7.0, 1.8.0 Dec 19, 2018

techknowlogick added some commits Jan 5, 2019

@techknowlogick

This comment has been minimized.

Copy link
Member

techknowlogick commented Jan 5, 2019

This PR fails on this line: https://github.com/go-gitea/gitea/blob/master/routers/init.go#L61

It seems the DB is created, and can be connected to, however Gitea hasn't set it as the DB to use. This part still needs more investigation.

@lunny

This comment has been minimized.

Copy link
Member Author

lunny commented Jan 5, 2019

should fix #5233

techknowlogick added some commits Mar 6, 2019

@techknowlogick
Copy link
Member

techknowlogick left a comment

CI Passes!

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Mar 6, 2019

@techknowlogick

This comment has been minimized.

Copy link
Member

techknowlogick commented Mar 6, 2019

@lafriks please review. your requested changes have been made.

@techknowlogick techknowlogick modified the milestones: 1.9.0, 1.8.0 Mar 6, 2019

@lunny

This comment has been minimized.

Copy link
Member Author

lunny commented Mar 8, 2019

@techknowlogick thanks for your commits!

techknowlogick added some commits Mar 12, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Mar 17, 2019

@sapk

sapk approved these changes Mar 17, 2019

changes have been made

@techknowlogick techknowlogick merged commit 4a6b011 into go-gitea:master Mar 17, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@lunny lunny deleted the lunny:lunny/mysql8_test branch Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.