Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test environment for Mysql8 #5234

Merged
merged 14 commits into from
Mar 17, 2019
Merged

Add test environment for Mysql8 #5234

merged 14 commits into from
Mar 17, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 31, 2018

No description provided.

@lunny lunny added this to the 1.7.0 milestone Oct 31, 2018
@codecov-io
Copy link

codecov-io commented Oct 31, 2018 •
edited
Loading

Codecov Report

Merging #5234 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5234   +/-   ##
=======================================
  Coverage   38.87%   38.87%           
=======================================
  Files         363      363           
  Lines       51210    51210           
=======================================
  Hits        19908    19908           
  Misses      28434    28434           
  Partials     2868     2868

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3ad5eb...25e698e. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 31, 2018
@jonasfranz
Copy link
Member

drone fails

@lunny
Copy link
Member Author

lunny commented Nov 2, 2018

I think the CI failed because both container listen on :3306

@techknowlogick
Copy link
Member

@lunny because the server is a docker container the IP will be different so it is ok if port is the same

lafriks
lafriks previously requested changes Nov 7, 2018
View reviewed changes
integrations/mysql8.ini.tmpl Outdated Show resolved Hide resolved
integrations/mysql8.ini.tmpl Outdated Show resolved Hide resolved
integrations/mysql8.ini.tmpl Outdated Show resolved Hide resolved
integrations/mysql8.ini.tmpl Outdated Show resolved Hide resolved
integrations/mysql8.ini.tmpl Outdated Show resolved Hide resolved
integrations/mysql8.ini.tmpl Outdated Show resolved Hide resolved
@techknowlogick techknowlogick modified the milestones: 1.7.0, 1.8.0 Dec 19, 2018
@techknowlogick
Copy link
Member

This PR fails on this line: https://github.com/go-gitea/gitea/blob/master/routers/init.go#L61

It seems the DB is created, and can be connected to, however Gitea hasn't set it as the DB to use. This part still needs more investigation.

@lunny
Copy link
Member Author

lunny commented Jan 5, 2019

should fix #5233

@techknowlogick techknowlogick added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Feb 24, 2019
@techknowlogick techknowlogick modified the milestones: 1.8.0, 1.9.0 Feb 26, 2019
techknowlogick
techknowlogick approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI Passes!

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 6, 2019
@techknowlogick
Copy link
Member

@lafriks please review. your requested changes have been made.

@techknowlogick techknowlogick modified the milestones: 1.9.0, 1.8.0 Mar 6, 2019
@lunny
Copy link
Member Author

lunny commented Mar 8, 2019

@techknowlogick thanks for your commits!

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 17, 2019
@techknowlogick techknowlogick dismissed lafriks’s stale review March 17, 2019 19:17

changes have been made

@techknowlogick techknowlogick merged commit 4a6b011 into go-gitea:master Mar 17, 2019
@lunny lunny deleted the lunny/mysql8_test branch March 18, 2019 00:36
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@sapk sapk sapk approved these changes

@adelowo adelowo adelowo approved these changes

@lafriks lafriks lafriks left review comments

Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@lunny @codecov-io @jonasfranz @techknowlogick @lafriks @sapk @adelowo @bkcsoft @GiteaBot