Remove maxlines option for file logger

[lafriks]

To support this feature it requires scanning whole log file on every ssh git operation that is not sensible. Remove this feature as there is already option for file size that is more reasonable to use and other log file rotation options.

Should fix #4450

[micw]

Looks good. I'd use something around 100 MB which comes closer to the initial 1 million lines.

[codecov-io]

Codecov Report

Merging #5282 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5282      +/-   ##
==========================================
- Coverage   37.38%   37.37%   -0.01%     
==========================================
  Files         312      312              
  Lines       46327    46313      -14     
==========================================
- Hits        17320    17311       -9     
+ Misses      26525    26520       -5     
  Partials     2482     2482

Impacted Files	Coverage Δ
modules/setting/setting.go	48.06% <100%> (-0.13%)	⬇️
modules/log/file.go	42.73% <100%> (-0.68%)	⬇️
modules/process/manager.go	76.81% <0%> (-4.35%)	⬇️
models/repo_list.go	64.55% <0%> (+1.26%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 078c404...8c3df19. Read the comment docs.

[micw]

@lafriks milestone 1.7.0? Since it's a fix for a performance-critical issue, I'd appreciate to see it in 1.6.

edit: sorry, did not see the backport label.

[adelowo]

Isn't 256MB still large enough?

[zeripath]

This seems sensible. Logrotate and log4j do not have this option either

[bkcsoft]

I would deprecate it and print a warning that it no longer does anything. Otherwise LGTM

[sapk]

@bkcsoft the breaking label should indicate this in the changelog.

[lafriks]

It's not documented anywhere and it would print on every git ssh operation, so I don't really see how we could deprecate it

[micw]

@lafriks Shouldn't I see this backport in https://github.com/go-gitea/gitea/commits/release/v1.6 now?

[lafriks]

@micw there is other PR for backport to release/v1.6 branch #5287

[lunny]

For further consideration, maybe we should use other maintained-well log library rather than we maintained a new one.