Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone issues and pull requests #5293

Merged
merged 6 commits into from Nov 29, 2018
Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 7, 2018

Will fix #1711

@lunny lunny added the type/enhancement An improvement of existing functionality label Nov 7, 2018
@lunny lunny added this to the 1.7.0 milestone Nov 7, 2018
@lunny
Copy link
Member Author

lunny commented Nov 7, 2018

screenshot
jietu20181107-220336

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 7, 2018
@codecov-io
Copy link

codecov-io commented Nov 7, 2018

Codecov Report

Merging #5293 into master will decrease coverage by <.01%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5293      +/-   ##
==========================================
- Coverage   37.56%   37.55%   -0.01%     
==========================================
  Files         316      317       +1     
  Lines       46783    46832      +49     
==========================================
+ Hits        17573    17587      +14     
- Misses      26717    26744      +27     
- Partials     2493     2501       +8
Impacted Files Coverage Δ
routers/repo/milestone.go 0% <0%> (ø)
routers/routes/routes.go 84.97% <100%> (+0.06%) ⬆️
models/issue.go 48.26% <100%> (+0.17%) ⬆️
models/issue_milestone.go 57.79% <55.55%> (-0.07%) ⬇️
routers/repo/issue.go 37.55% <64.44%> (+5.86%) ⬆️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_indexer.go 44.49% <0%> (-3.82%) ⬇️
models/error.go 33.41% <0%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d847e...4bfa751. Read the comment docs.

routers/repo/milestone.go Outdated Show resolved Hide resolved
@adelowo
Copy link
Member

adelowo commented Nov 7, 2018

@lunny Would it be possible to put something like "92 opened, 10 closed" like Github ?

@lunny
Copy link
Member Author

lunny commented Nov 8, 2018

@adelowo see the screenshot, I think I have put them there and added some filters which is better than github.

@adelowo
Copy link
Member

adelowo commented Nov 8, 2018

@lunny Sorry about that... I am so used to Github writing it in "plain text" ...

@lafriks lafriks added the type/changelog Adds the changelog for a new Gitea version label Nov 28, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 28, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 28, 2018
@lunny lunny merged commit 2dc805c into go-gitea:master Nov 29, 2018
@lunny lunny deleted the lunny/milestone_issues branch November 29, 2018 01:46
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

milestone listing miss PRs
7 participants