Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repository deletion when there is large number of issues in it #5426

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Fix repository deletion when there is large number of issues in it #5426

merged 2 commits into from
Nov 30, 2018

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 29, 2018

Should fix #5238

@lunny lunny added this to the 1.7.0 milestone Nov 29, 2018
@lunny lunny mentioned this pull request Nov 29, 2018
Closed
7 tasks
@codecov-io
Copy link

Codecov Report

Merging #5426 into master will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5426      +/-   ##
==========================================
+ Coverage   37.55%   37.59%   +0.04%     
==========================================
  Files         317      317              
  Lines       46832    46831       -1     
==========================================
+ Hits        17588    17608      +20     
+ Misses      26744    26724      -20     
+ Partials     2500     2499       -1
Impacted Files Coverage Δ
models/repo.go 42.81% <0%> (+0.02%) ⬆️
models/repo_indexer.go 50% <0%> (+5.5%) ⬆️
modules/indexer/repo.go 69.84% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc805c...b672391. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 29, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 29, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 30, 2018
@lafriks lafriks changed the title Fix delete repository failed Fix repository deletion when there is large number of issues in it Nov 30, 2018
@lafriks lafriks merged commit f80b4f4 into go-gitea:master Nov 30, 2018
@lafriks
Copy link
Member

lafriks commented Nov 30, 2018

@lunny please send backport

@lunny lunny deleted the lunny/fix_delete_comment branch November 30, 2018 13:29
lunny added a commit to lunny/gitea that referenced this pull request Nov 30, 2018
@lunny
Fix repository deletion when there is large number of issues in it (g…
22e0df4 
…o-gitea#5426)
@lunny lunny mentioned this pull request Nov 30, 2018
Merged
techknowlogick pushed a commit that referenced this pull request Nov 30, 2018
@lunny @techknowlogick
Fix repository deletion when there is large number of issues in it (#…
e406dc0 
…5426) (#5434)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@Bwko Bwko Bwko approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Can't delete repository: HTTP 500 DeleteRepository: too many SQL variables
5 participants
@lunny @codecov-io @lafriks @Bwko @bkcsoft