New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repository deletion when there is large number of issues in it #5426

Merged
merged 2 commits into from Nov 30, 2018

Conversation

5 participants
@lunny
Copy link
Member

lunny commented Nov 29, 2018

Should fix #5238

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 29, 2018

Codecov Report

Merging #5426 into master will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5426      +/-   ##
==========================================
+ Coverage   37.55%   37.59%   +0.04%     
==========================================
  Files         317      317              
  Lines       46832    46831       -1     
==========================================
+ Hits        17588    17608      +20     
+ Misses      26744    26724      -20     
+ Partials     2500     2499       -1
Impacted Files Coverage Δ
models/repo.go 42.81% <0%> (+0.02%) ⬆️
models/repo_indexer.go 50% <0%> (+5.5%) ⬆️
modules/indexer/repo.go 69.84% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc805c...b672391. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 label Nov 29, 2018

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels Nov 29, 2018

@Bwko

Bwko approved these changes Nov 30, 2018

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Nov 30, 2018

@lafriks lafriks changed the title Fix delete repository failed Fix repository deletion when there is large number of issues in it Nov 30, 2018

@lafriks lafriks merged commit f80b4f4 into go-gitea:master Nov 30, 2018

1 check passed

continuous-integration/drone/pr the build was successful
Details
@lafriks

This comment has been minimized.

Copy link
Member

lafriks commented Nov 30, 2018

@lunny please send backport

@lunny lunny deleted the lunny:lunny/fix_delete_comment branch Nov 30, 2018

lunny added a commit to lunny/gitea that referenced this pull request Nov 30, 2018

techknowlogick added a commit that referenced this pull request Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment