New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug when a read perm user to edit his issue #5516

Merged
merged 2 commits into from Dec 12, 2018

Conversation

6 participants
@lunny
Copy link
Member

lunny commented Dec 11, 2018

Will fix #4168

@lunny lunny added this to the 1.7.0 milestone Dec 11, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 11, 2018

Codecov Report

Merging #5516 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5516      +/-   ##
==========================================
+ Coverage   37.57%   37.57%   +<.01%     
==========================================
  Files         319      319              
  Lines       46949    46949              
==========================================
+ Hits        17641    17642       +1     
+ Misses      26798    26795       -3     
- Partials     2510     2512       +2
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af6bce3...38875be. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 label Dec 11, 2018

@lunny lunny referenced this pull request Dec 11, 2018

Closed

Can not edit issue description after creation #4168

1 of 7 tasks complete

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels Dec 11, 2018

@lunny lunny referenced this pull request Dec 12, 2018

Open

Error editing initial content on pull request #4755

2 of 7 tasks complete
@lunny

This comment has been minimized.

Copy link
Member

lunny commented Dec 12, 2018

will also fix #4755

@Bwko

Bwko approved these changes Dec 12, 2018

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Dec 12, 2018

@techknowlogick techknowlogick merged commit f0374ad into go-gitea:master Dec 12, 2018

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

lunny added a commit to lunny/gitea that referenced this pull request Dec 12, 2018

@lunny lunny deleted the lunny:lunny/fix_read_perm_edit branch Dec 12, 2018

@lunny lunny added the backport/done label Dec 12, 2018

techknowlogick added a commit that referenced this pull request Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment