New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix indexer reindex bug when gitea restart #5563

Merged
merged 2 commits into from Dec 19, 2018

Conversation

5 participants
@lunny
Copy link
Member

lunny commented Dec 19, 2018

Caused by #3452 and will fix #5325.
On #3452, we add an index version checking on metajson file, but forgot to save it on the file when create a new indexer directory. :(

lunny added some commits Dec 19, 2018

@lunny lunny added the kind/bug label Dec 19, 2018

@lunny lunny added this to the 1.7.0 milestone Dec 19, 2018

@lunny lunny added the backport/v1.6 label Dec 19, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 19, 2018

Codecov Report

Merging #5563 into master will decrease coverage by <.01%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5563      +/-   ##
==========================================
- Coverage   37.57%   37.57%   -0.01%     
==========================================
  Files         321      321              
  Lines       47182    47192      +10     
==========================================
+ Hits        17729    17732       +3     
- Misses      26913    26918       +5     
- Partials     2540     2542       +2
Impacted Files Coverage Δ
modules/indexer/issue.go 65.82% <55.55%> (-1.75%) ⬇️
modules/indexer/repo.go 63.35% <55.55%> (-0.93%) ⬇️
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️
models/repo_indexer.go 48.3% <0%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c649635...062e0ca. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 label Dec 19, 2018

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels Dec 19, 2018

@sapk

sapk approved these changes Dec 19, 2018

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Dec 19, 2018

@lunny lunny merged commit b65e37e into go-gitea:master Dec 19, 2018

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

lunny added a commit to lunny/gitea that referenced this pull request Dec 19, 2018

fix indexer reindex bug when gitea restart (go-gitea#5563)
* fix issue indexer bug reindex when restart gitea

* also fix code indexer reindex when gitea restart

@lunny lunny deleted the lunny:lunny/fix_issue_indexer branch Dec 19, 2018

techknowlogick added a commit that referenced this pull request Dec 19, 2018

fix indexer reindex bug when gitea restart (#5563) (#5564)
* fix issue indexer bug reindex when restart gitea

* also fix code indexer reindex when gitea restart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment