New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug on modifying sshd username #5624

Merged
merged 1 commit into from Jan 2, 2019

Conversation

7 participants
@MoshiBin
Copy link
Contributor

MoshiBin commented Jan 2, 2019

Should fix #5623

Since the regex isn't matching the end-of-line, when using a user whose username starts with "git" it will perform an invalid replace (gitea -> giteaea, git-suffix -> git-suffix-suffix).

Matching against EOL should resolve this issue.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 2, 2019

Codecov Report

Merging #5624 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5624   +/-   ##
=======================================
  Coverage   37.81%   37.81%           
=======================================
  Files         322      322           
  Lines       47474    47474           
=======================================
  Hits        17954    17954           
  Misses      26933    26933           
  Partials     2587     2587

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74b9a13...468b022. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 label Jan 2, 2019

@bkcsoft bkcsoft added lgtm/need 1 and removed lgtm/need 2 labels Jan 2, 2019

@bkcsoft bkcsoft added lgtm/done and removed lgtm/need 1 labels Jan 2, 2019

@techknowlogick techknowlogick merged commit 7606061 into go-gitea:master Jan 2, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@techknowlogick techknowlogick added this to the 1.7.0 milestone Jan 2, 2019

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Jan 3, 2019

Should this be back port to v1.6

@lafriks

This comment has been minimized.

Copy link
Member

lafriks commented Jan 3, 2019

Please backport to release/1.6 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment