New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to commit on Github #5644

Open
wants to merge 2 commits into
base: master
from

Conversation

4 participants
@mcnesium
Copy link
Contributor

mcnesium commented Jan 5, 2019

What about linking the commit in the footer to the corresponding page on Github?

mcnesium added some commits Jan 5, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 5, 2019

Codecov Report

Merging #5644 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5644      +/-   ##
==========================================
- Coverage   37.81%   37.81%   -0.01%     
==========================================
  Files         322      322              
  Lines       47489    47489              
==========================================
- Hits        17959    17957       -2     
- Misses      26941    26943       +2     
  Partials     2589     2589
Impacted Files Coverage Δ
models/repo_list.go 63.29% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6311e4c...4499427. Read the comment docs.

@@ -1,7 +1,7 @@
<footer>
<div class="ui container">
<div class="ui left">
© Gitea {{if (or .ShowFooterVersion .PageIsAdmin)}}{{.i18n.Tr "version"}}: {{AppVer}}{{end}} {{if ShowFooterTemplateLoadTime}}{{.i18n.Tr "page"}}: <strong>{{LoadTimes .PageStartTime}}</strong> {{.i18n.Tr "template"}}: <strong>{{call .TmplLoadTimes}}</strong>{{end}}
© Gitea {{if (or .ShowFooterVersion .PageIsAdmin)}}{{.i18n.Tr "version"}}: <a href="https://github.com/go-gitea/gitea/commit/{{AppVer}}">{{AppVer}}</a>{{end}} {{if ShowFooterTemplateLoadTime}}{{.i18n.Tr "page"}}: <strong>{{LoadTimes .PageStartTime}}</strong> {{.i18n.Tr "template"}}: <strong>{{call .TmplLoadTimes}}</strong>{{end}}

This comment has been minimized.

@techknowlogick

techknowlogick Jan 5, 2019

Member

{{AppVer}} isn't always a git hash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment