Refactor repo.isBare to repo.isEmpty #5629

[zeripath]

Gitea's models/repo.go Repository.IsBare means that a repository is empty rather than that the repository is actually a bare repository in git terms. This is confusing and this PR changes Gitea so that all references to bare only refer to git bare.

Fix #5629

Signed-off-by: Andrew Thornton art27@cantab.net

[codecov-io]

Codecov Report

Merging #5714 into master will decrease coverage by 0.02%.
The diff coverage is 38.33%.

@@            Coverage Diff             @@
##           master    #5714      +/-   ##
==========================================
- Coverage   37.76%   37.73%   -0.03%     
==========================================
  Files         326      327       +1     
  Lines       47779    47803      +24     
==========================================
- Hits        18043    18038       -5     
- Misses      27146    27170      +24     
- Partials     2590     2595       +5

Impacted Files	Coverage Δ
models/migrations/migrations.go	2.61% <ø> (ø)	⬆️
routers/repo/view.go	47.3% <0%> (+1.19%)	⬆️
routers/repo/pull.go	34.48% <0%> (ø)	⬆️
modules/context/api.go	50.81% <0%> (ø)	⬆️
models/migrations/v78.go	0% <0%> (ø)
routers/api/v1/repo/file.go	22.8% <0%> (ø)	⬆️
routers/repo/repo.go	20.82% <100%> (ø)	⬆️
models/action.go	60.32% <33.33%> (ø)	⬆️
modules/context/repo.go	59.78% <50%> (ø)	⬆️
models/repo.go	43.88% <57.14%> (ø)	⬆️
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9edc829...1a0f2f0. Read the comment docs.

[techknowlogick]

Just putting a note here in case we have problems in the future, I've tested this statement sucessfuly on SQLite, and MySQL, we probably won't run into problems with this raw SQL on Postgres, and hopefully we won't run into it on MSSQL (can't test that DB right now sadly).

If errors do arise from this statement, then we'll have to select rows in batches and loop while doing updates on each using XORM Update function.

[lafriks]

Why not just rename column instead of adding/removing?

ALTER TABLE "repository" RENAME COLUMN "is_bare" TO "is_empty";

for MSSQL you have to use:

EXEC sp_rename 'repository.is_bare', 'is_empty', 'COLUMN'

[zeripath]

is the line

strings.Contains(err.Error(), "no such column") 

still correct?

[lafriks]

hard to tell, need to verify that. Also x.Sync is not needed any more otherwise it will add column and rename will fail