Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure valid git author names passed in signatures #5774

Merged
merged 7 commits into from
Jan 24, 2019
Merged

Ensure valid git author names passed in signatures #5774

merged 7 commits into from
Jan 24, 2019

Commits on Jan 20, 2019

  1. Ensure valid git author names passed in signatures 

    Fix go-gitea#5772 - Git author names are not allowed to include `\n` `<` or `>` and
must not be empty. Ensure that the name passed in a signature is valid.

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    8f0a35f View commit details
    Browse the repository at this point in the history

  2. Account for pathologically named external users 

    LDAP and the like usernames are not checked in the same way that users who signup are.
Therefore just ensure that user names are also git safe and if totally pathological -
Set them to "user-$UID"

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    67fcd64 View commit details
    Browse the repository at this point in the history

  3. Add Tests and adjust test users 

    Make our testcases a little more pathological so that we be sure that integration
tests have a chance to spot these cases.

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    1ae279a View commit details
    Browse the repository at this point in the history

  4. Update spacing in imports 

    Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed Jan 20, 2019
    Configuration menu
    Copy the full SHA
    40bdc55 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2019

  1. Merge branch 'master' into issue-5772-escape-full-name-in-git-author

    @zeripath
    zeripath committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    bc55536 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2019

  1. Merge branch 'master' into issue-5772-escape-full-name-in-git-author

    @lunny
    lunny committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    b4ea12d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into issue-5772-escape-full-name-in-git-author

    @lunny
    lunny committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    b221f7b View commit details
    Browse the repository at this point in the history