Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow empty titles #5785

Merged
merged 6 commits into from Jan 21, 2019
Merged

Disallow empty titles #5785

merged 6 commits into from Jan 21, 2019

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Jan 20, 2019

Fixes #5781

  • Issue titles can consist of just spaces. Such issues cannot be selected in the issue list.
  • Wiki page titles can consist of just spaces. Such pages cannot be selected in the wiki tab.
  • Pull request titles can consist of just spaces. Such pull requests cannot be selected in the pull request tab.

@codecov-io
Copy link

codecov-io commented Jan 20, 2019 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@8a92544). Click here to learn what that means.
The diff coverage is 11.76%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5785   +/-   ##
=========================================
  Coverage          ?   37.72%           
=========================================
  Files             ?      327           
  Lines             ?    47866           
  Branches          ?        0           
=========================================
  Hits              ?    18059           
  Misses            ?    27211           
  Partials          ?     2596
Impacted Files Coverage Δ
routers/repo/wiki.go 44.59% <0%> (ø)
routers/repo/issue.go 36.55% <0%> (ø)
routers/repo/pull.go 34.22% <0%> (ø)
modules/util/util.go 63.46% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a92544...38c623b. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 20, 2019
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 20, 2019
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 21, 2019
@lafriks lafriks added this to the 1.8.0 milestone Jan 21, 2019
@lafriks lafriks merged commit e1fcd6b into go-gitea:master Jan 21, 2019
@lafriks
Copy link
Member

lafriks commented Jan 21, 2019

Please send backport to release/v1.7

@adelowo
Copy link
Member Author

adelowo commented Jan 21, 2019

Yeah... Will do that in a bit

@adelowo adelowo deleted the empty_titles branch January 21, 2019 12:55
adelowo added a commit to adelowo/gitea that referenced this pull request Jan 21, 2019
@adelowo
Disallow empty titles (go-gitea#5785)
3b6744b 
* add util method and tests

* make sure the title of an issue cannot be empty

* wiki title cannot be empty

* pull request title cannot be empty

* update to make use of the new util methof
@adelowo adelowo mentioned this pull request Jan 21, 2019
Merged
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Jan 21, 2019
lafriks pushed a commit that referenced this pull request Jan 21, 2019
@adelowo @lafriks
Disallow empty titles (#5785) (#5794)
4577cdd 
* add util method and tests

* make sure the title of an issue cannot be empty

* wiki title cannot be empty

* pull request title cannot be empty

* update to make use of the new util methof
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Disallow empty titles
7 participants
@adelowo @codecov-io @lafriks @zeripath @techknowlogick @bkcsoft @jonasfranz