New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error while adding a dependency via UI. #5862

Merged
merged 2 commits into from Jan 27, 2019

Conversation

9 participants
@HarshitOnGitHub
Copy link
Contributor

HarshitOnGitHub commented Jan 26, 2019

We were not checking if the Repo attribute is loaded or not before using it.

image

Fixes: #5783.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 26, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@2d8520d). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5862   +/-   ##
=========================================
  Coverage          ?   37.85%           
=========================================
  Files             ?      328           
  Lines             ?    48326           
  Branches          ?        0           
=========================================
  Hits              ?    18292           
  Misses            ?    27401           
  Partials          ?     2633
Impacted Files Coverage Δ
models/issue_comment.go 46% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d8520d...d7102c8. Read the comment docs.

Show resolved Hide resolved models/issue_comment.go Outdated

@techknowlogick techknowlogick added this to the 1.8.0 milestone Jan 27, 2019

@HarshitOnGitHub HarshitOnGitHub force-pushed the HarshitOnGitHub:Issue_5783 branch from 45d98fe to 668cbef Jan 27, 2019

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Jan 27, 2019

@zeripath

This comment has been minimized.

Copy link
Contributor

zeripath commented Jan 27, 2019

Thanks @HarshitOnGitHub

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Jan 27, 2019

@lafriks lafriks merged commit 7e8242d into go-gitea:master Jan 27, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

bmackinney added a commit to bmackinney/gitea that referenced this pull request Jan 27, 2019

@lunny

This comment has been minimized.

Copy link
Member

lunny commented Jan 28, 2019

@HarshitOnGitHub could you send a backport to release/v1.7?

@HarshitOnGitHub

This comment has been minimized.

Copy link
Contributor Author

HarshitOnGitHub commented Jan 28, 2019

@lunny Done.

zeripath added a commit that referenced this pull request Jan 28, 2019

@adelowo

This comment has been minimized.

Copy link
Member

adelowo commented Jan 28, 2019

@zeripath Can you add backport/done label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment