modules/context/auth.go: fix redirect loop #5965
Conversation
GiteaBot
added
the
lgtm/need 2
|
Heya! I've actually just tested this on my own server and noticed the bug. It's not good that this was missed - I'm sorry about that. We should probably change our integration tests to ensure we hit these potential bugs - always query Gitea without the suburl but always expect the suburl back etc. In terms of fixing the other redirects - perhaps we should add a redirected from Param to the query and if we end up attempting to redirect back to the same place we should return forbidden. |
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #5965 +/- ##
==========================================
+ Coverage 38.86% 38.86% +<.01%
==========================================
Files 345 345
Lines 49508 49508
==========================================
+ Hits 19241 19243 +2
+ Misses 27485 27482 -3
- Partials 2782 2783 +1
Continue to review full report at Codecov.
|
|
Please send back port to release/v1.7 |
| @@ -42,7 +42,7 @@ func Toggle(options *ToggleOptions) macaron.Handler { | |||
| // prevent infinite redirection | |||
| // also make sure that the form cannot be accessed by | |||
| // users who don't need this | |||
| if ctx.Req.URL.Path == setting.AppSubURL+"/user/settings/change_password" { | |||
| if ctx.Req.URL.Path == "/user/settings/change_password" { | |||
There was a problem hiding this comment.
this change makes works the problem in #5482
|
how can i determine if when this will hit binary release? i'm having this issue on httpd although working w/colleague to determine our current version |
|
This was included as a backport in |
Closes #5815
Heatmap loop still persists.