New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/context/auth.go: fix redirect loop #5965

Merged
merged 2 commits into from Feb 17, 2019

Conversation

7 participants
@xdch47
Copy link
Contributor

xdch47 commented Feb 4, 2019

Closes #5815

Heatmap loop still persists.

Show resolved Hide resolved modules/context/auth.go

@GiteaBot GiteaBot added the lgtm/need 2 label Feb 4, 2019

@zeripath

This comment has been minimized.

Copy link
Contributor

zeripath commented Feb 5, 2019

Heya! I've actually just tested this on my own server and noticed the bug. It's not good that this was missed - I'm sorry about that.

We should probably change our integration tests to ensure we hit these potential bugs - always query Gitea without the suburl but always expect the suburl back etc.

In terms of fixing the other redirects - perhaps we should add a redirected from Param to the query and if we end up attempting to redirect back to the same place we should return forbidden.

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 16, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 17, 2019

Codecov Report

Merging #5965 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5965      +/-   ##
==========================================
+ Coverage   38.86%   38.86%   +<.01%     
==========================================
  Files         345      345              
  Lines       49508    49508              
==========================================
+ Hits        19241    19243       +2     
+ Misses      27485    27482       -3     
- Partials     2782     2783       +1
Impacted Files Coverage Δ
modules/context/auth.go 21.87% <0%> (ø) ⬆️
models/unit.go 14.28% <0%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b72c00...eba5b05. Read the comment docs.

@lunny lunny merged commit 5e7dee0 into go-gitea:master Feb 17, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details
@lunny

This comment has been minimized.

Copy link
Member

lunny commented Feb 17, 2019

Please send back port to release/v1.7

xdch47 added a commit to xdch47/gitea that referenced this pull request Feb 17, 2019

zeripath added a commit that referenced this pull request Feb 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment