Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover panic in orgmode.Render if bad orgfile (#4982) (#5903) #6097

Merged
merged 1 commit into from Feb 16, 2019

Conversation

@zeripath
Copy link
Contributor

commented Feb 16, 2019

Backport #5903 to v1.7

This PR protects against the panic referred to in chaseadmsio/goorgeous#82
by recovering from the panic and just returning the raw bytes if
there is an error.

Signed-off-by: Andrew Thornton art27@cantab.net

Recover panic in orgmode.Render if bad orgfile (#4982) (#5903)
This PR protects against the panic referred to in chaseadmsio/goorgeous#82
by recovering from the panic and just returning the raw bytes if
there is an error.

Signed-off-by: Andrew Thornton <art27@cantab.net>

@zeripath zeripath added this to the 1.7.3 milestone Feb 16, 2019

@zeripath

This comment has been minimized.

Copy link
Contributor Author

commented Feb 16, 2019

Sorry for the delay.

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Feb 16, 2019

@lafriks lafriks removed the backport/v1.7 label Feb 16, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 16, 2019

@techknowlogick techknowlogick merged commit 2e1540e into go-gitea:release/v1.7 Feb 16, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@zeripath zeripath deleted the zeripath:backport-5903 branch Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.