Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug when update owner team then visit team's repo return 404 #6119

Merged
merged 2 commits into from
Feb 22, 2019
Merged

fix bug when update owner team then visit team's repo return 404 #6119

merged 2 commits into from
Feb 22, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 19, 2019

Will fix #6094

@lunny lunny added this to the 1.8.0 milestone Feb 19, 2019
@codecov-io
Copy link

codecov-io commented Feb 19, 2019 •
edited
Loading

Codecov Report

Merging #6119 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6119      +/-   ##
==========================================
+ Coverage   38.83%   38.83%   +<.01%     
==========================================
  Files         354      354              
  Lines       50174    50177       +3     
==========================================
+ Hits        19485    19487       +2     
+ Misses      27866    27865       -1     
- Partials     2823     2825       +2
Impacted Files Coverage Δ
routers/org/teams.go 0% <ø> (ø) ⬆️
models/repo_permission.go 72.02% <100%> (+1.03%) ⬆️
models/unit.go 0% <0%> (-14.29%) ⬇️
models/repo_list.go 66.84% <0%> (-1.06%) ⬇️
routers/repo/view.go 41.08% <0%> (-1%) ⬇️
models/org_team.go 50.78% <0%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df30010...cfc9f76. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 19, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 21, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 22, 2019
@techknowlogick techknowlogick merged commit 134e555 into go-gitea:master Feb 22, 2019
@techknowlogick
Copy link
Member

@lunny please backport

@lunny lunny deleted the lunny/fix_update_owner_team branch February 23, 2019 00:51
lunny added a commit to lunny/gitea that referenced this pull request Feb 23, 2019
@lunny
fix bug when update owner team then visit team's repo return 404 (go-…
0752550 
…gitea#6119)
@lunny lunny mentioned this pull request Feb 23, 2019
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Feb 23, 2019
techknowlogick pushed a commit that referenced this pull request Feb 23, 2019
@lunny @techknowlogick
fix bug when update owner team then visit team's repo return 404 (#6119…
585dd13 
…) (#6166)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Be owner but can not access the org's project(s), show 404
6 participants
@lunny @codecov-io @techknowlogick @lafriks @zeripath @GiteaBot