Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug user could change private repository to public when force private enabled. #6156

Merged
merged 2 commits into from Feb 22, 2019

Conversation

@lunny
Copy link
Member

commented Feb 22, 2019

No description provided.

@lunny lunny added this to the 1.8.0 milestone Feb 22, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Feb 22, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@134e555). Click here to learn what that means.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6156   +/-   ##
=========================================
  Coverage          ?   38.83%           
=========================================
  Files             ?      354           
  Lines             ?    50183           
  Branches          ?        0           
=========================================
  Hits              ?    19490           
  Misses            ?    27868           
  Partials          ?     2825
Impacted Files Coverage Δ
routers/repo/setting.go 10.32% <16.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 134e555...d5dbefd. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Feb 22, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 22, 2019

@zeripath zeripath merged commit 4a2fbbe into go-gitea:master Feb 22, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details
@zeripath

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2019

@lunny could you send backport?

@lunny lunny deleted the lunny:lunny/fix_force_private branch Feb 23, 2019

lunny added a commit to lunny/gitea that referenced this pull request Feb 23, 2019

@lunny lunny added the backport/done label Feb 23, 2019

zeripath added a commit that referenced this pull request Feb 23, 2019

Mikescher added a commit to Mikescher/gitea that referenced this pull request Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.