Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug user could change private repository to public when force private enabled. #6156

Merged
merged 2 commits into from
Feb 22, 2019
Merged

fix bug user could change private repository to public when force private enabled. #6156

merged 2 commits into from
Feb 22, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 22, 2019

No description provided.

@lunny lunny added this to the 1.8.0 milestone Feb 22, 2019
@codecov-io
Copy link

codecov-io commented Feb 22, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@134e555). Click here to learn what that means.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6156   +/-   ##
=========================================
  Coverage          ?   38.83%           
=========================================
  Files             ?      354           
  Lines             ?    50183           
  Branches          ?        0           
=========================================
  Hits              ?    19490           
  Misses            ?    27868           
  Partials          ?     2825
Impacted Files Coverage Δ
routers/repo/setting.go 10.32% <16.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 134e555...d5dbefd. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 22, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 22, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 22, 2019
@zeripath zeripath merged commit 4a2fbbe into go-gitea:master Feb 22, 2019
@zeripath
Copy link
Contributor

@lunny could you send backport?

@lunny lunny deleted the lunny/fix_force_private branch February 23, 2019 00:49
lunny added a commit to lunny/gitea that referenced this pull request Feb 23, 2019
@lunny
fix bug user could change private repository to public when force pri…
faa5018 
…vate enabled. (go-gitea#6156)
@lunny lunny mentioned this pull request Feb 23, 2019
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Feb 23, 2019
zeripath pushed a commit that referenced this pull request Feb 23, 2019
@lunny @zeripath
fix bug user could change private repository to public when force pri…
55063f2 
…vate enabled. (#6156) (#6165)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lunny @codecov-io @zeripath @appleboy @techknowlogick @GiteaBot