UI: Fix scrollbar always present on page body #6177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6177 +/- ##
=======================================
Coverage 38.87% 38.87%
=======================================
Files 354 354
Lines 50184 50184
=======================================
Hits 19508 19508
Misses 27851 27851
Partials 2825 2825Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
lafriks
approved these changes
Feb 25, 2019
GiteaBot
added
lgtm/need 1
adelowo
approved these changes
Feb 25, 2019
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
28fcbf3 had reintroduced a small issue where the main page scrollbar was present even if there was no real scrollable content. To fix, I changed the height of the footer to
flex-basiswhich works better thanheight, which fixes the issue in all Browsers except IE 11 where I had to additionally set the overflow on body toautoto display scrollbars only when needed.