Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix display dashboard even if require to change password #6214

Merged
merged 2 commits into from Feb 28, 2019

Conversation

5 participants
@lunny
Copy link
Member

lunny commented Feb 28, 2019

Before this PR, when a user was asked to change his password, he will still view dashboard.

@lunny lunny added this to the 1.8.0 milestone Feb 28, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 28, 2019

Codecov Report

Merging #6214 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6214      +/-   ##
==========================================
- Coverage   38.86%   38.86%   -0.01%     
==========================================
  Files         354      354              
  Lines       50204    50210       +6     
==========================================
- Hits        19513    19512       -1     
- Misses      27867    27872       +5     
- Partials     2824     2826       +2
Impacted Files Coverage Δ
modules/context/auth.go 18.84% <0%> (-0.28%) ⬇️
routers/home.go 45.45% <0%> (-0.85%) ⬇️
modules/avatar/avatar.go 81.25% <0%> (-18.75%) ⬇️
models/repo_list.go 66.84% <0%> (-1.06%) ⬇️
routers/repo/view.go 42.07% <0%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48c101a...7c96bf7. Read the comment docs.

Show resolved Hide resolved modules/context/auth.go Outdated

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Feb 28, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Feb 28, 2019

@lunny lunny merged commit c812ba7 into go-gitea:master Feb 28, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@lunny lunny deleted the lunny:lunny/change_password branch Feb 28, 2019

lunny added a commit to lunny/gitea that referenced this pull request Feb 28, 2019

fix display dashboard even if require to change password (go-gitea#6214)
* fix display dashboard even if require to change password

* fix comments

@lunny lunny added the backport/done label Feb 28, 2019

lunny added a commit that referenced this pull request Feb 28, 2019

fix display dashboard even if require to change password (#6214) (#6215)
* fix display dashboard even if require to change password

* fix comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.