Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix ParsePatch function to work with quoted diff --git strings #6323
@@ Coverage Diff @@ ## master #6323 +/- ## ========================================== + Coverage 38.8% 38.83% +0.03% ========================================== Files 359 359 Lines 51175 51182 +7 ========================================== + Hits 19857 19877 +20 + Misses 28447 28435 -12 + Partials 2871 2870 -1
zeripath left a comment
I wonder if there's a way of testing the whole pipeline through an integration test. But this is not necessarily required for this case. I just worry that dumping the diffs in rather than generating the diffs means that we can't add more pathological cases.
(If you follow the example in https://github.com/go-gitea/gitea/blob/master/integrations/git_test.go or https://github.com/go-gitea/gitea/blob/master/integrations/ssh_key_test.go you should be able to create story like tests.)