Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug manifest.json will not request with cookie so that session will created every request #6372

Merged
merged 1 commit into from Mar 19, 2019

Conversation

@lunny lunny added this to the 1.9.0 milestone Mar 19, 2019

@lunny lunny referenced this pull request Mar 19, 2019

Closed

"data/sessions" folder growed up and used 100% inodes #6320

2 of 7 tasks complete
@codecov-io

This comment has been minimized.

Copy link

commented Mar 19, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@f7f2f12). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6372   +/-   ##
=========================================
  Coverage          ?   38.87%           
=========================================
  Files             ?      365           
  Lines             ?    51341           
  Branches          ?        0           
=========================================
  Hits              ?    19957           
  Misses            ?    28511           
  Partials          ?     2873

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7f2f12...767a7c3. Read the comment docs.

@lunny

This comment has been minimized.

Copy link
Member Author

commented Mar 19, 2019

@FloThinksPi My first idea is same as you to disable session on public resources. But I found I'm not familiar with macaron enough to do that in a short time and I think I will send another PR to do that.

@FloThinksPi

This comment has been minimized.

Copy link

commented Mar 19, 2019

Yea this will do it as quick fix 👍

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Mar 19, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Mar 19, 2019

@techknowlogick techknowlogick merged commit ce646fd into go-gitea:master Mar 19, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details
@techknowlogick

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

@lunny please create backport PRs

Mikescher added a commit to Mikescher/gitea that referenced this pull request Mar 20, 2019

@lunny

This comment has been minimized.

Copy link
Member Author

commented Mar 20, 2019

@FloThinksPi Yes, please. And I think maybe some other resources routes should also disable session.

lunny added a commit to lunny/gitea that referenced this pull request Mar 20, 2019

lunny added a commit to lunny/gitea that referenced this pull request Mar 20, 2019

@lunny lunny added the backport/done label Mar 20, 2019

@lunny lunny deleted the lunny:lunny/fix_manifest_json branch Mar 20, 2019

techknowlogick added a commit that referenced this pull request Mar 20, 2019

techknowlogick added a commit that referenced this pull request Mar 20, 2019

@FloThinksPi

This comment has been minimized.

Copy link

commented Mar 20, 2019

Deleted my comments cause i will send it to security@gitea just to be sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.