Handle redirects for git clone commands #6688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
GiteaBot
added
the
lgtm/need 2
|
Tests fail |
Add support for repo_redirect objects in the git smart http handler so that when a user clones a repo that has been moved or renamed, they are redirected to the new location. This requires that the query string be included in the redirect as well, so that is added. Signed-off-by: James E. Blair <jeblair@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #6688 +/- ##
==========================================
+ Coverage 40.99% 40.99% +<.01%
==========================================
Files 421 421
Lines 57915 57931 +16
==========================================
+ Hits 23740 23747 +7
- Misses 31017 31023 +6
- Partials 3158 3161 +3
Continue to review full report at Codecov.
|
|
I've updated this to correct the issues with the tests. The new approach doesn't need any special handling for the ".git" suffix, so I edited the PR description to reflect that. |
zeripath
approved these changes
Apr 24, 2019
GiteaBot
added
lgtm/need 1
adelowo
approved these changes
Apr 24, 2019
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle redirects in git clone commands
Add support for repo_redirect objects in the git smart http handler so that when a user clones a repo that has been moved or renamed, they are redirected to the new location.
This requires that the query string be included in the redirect as well, so that is added.