Add team option to grant rights for all organization repositories #6791

ngourdon · 2019-04-28T17:39:42Z

add new option to team
use the new option for owner team to unify the processing
grant access to members
update team API

Fix #6409 and #2654

related PR go-gitea/go-sdk#166

models/migrations/v85.go

models/org_team.go

…owner

ngourdon · 2019-05-09T07:47:19Z

Behaviour is the same for Owners teams and teams which includes all repositories.
I added a handling in TransferOwnership which was missed.
All repositories are still added to teams which includes all repositories because it is how it is for Owners teams and some functions won't work without it (like access.go:recalculateTeamAccesses or org_team.go:AddTeamMember.
Ready for review.

lafriks · 2019-05-09T19:47:38Z

Drone fails

ngourdon · 2019-05-09T20:09:32Z

There's still a change in the gitea sdk to add the new field IncludesAllRepositories in the API.
This fails the task test-vendor in the CI build.

There is a PR go-gitea/go-sdk#166 opened for this change.

codecov-io · 2019-05-12T16:19:08Z

Codecov Report

Merging #6791 into master will increase coverage by 0.01%.
The diff coverage is 40%.

@@            Coverage Diff            @@
##           master   #6791      +/-   ##
=========================================
+ Coverage   41.19%   41.2%   +0.01%     
=========================================
  Files         469     470       +1     
  Lines       63536   63591      +55     
=========================================
+ Hits        26171   26205      +34     
- Misses      33943   33960      +17     
- Partials     3422    3426       +4

Impacted Files	Coverage Δ
models/migrations/migrations.go	`1.32% <ø> (ø)`	⬆️
modules/auth/org.go	`0% <ø> (ø)`	⬆️
models/migrations/v90.go	`0% <0%> (ø)`
routers/org/teams.go	`0% <0%> (ø)`	⬆️
models/org.go	`69.54% <100%> (+0.42%)`	⬆️
routers/api/v1/convert/convert.go	`84.03% <100%> (+0.07%)`	⬆️
routers/api/v1/org/team.go	`25.93% <100%> (+0.34%)`	⬆️
models/repo.go	`49.23% <17.64%> (+0.63%)`	⬆️
models/org_team.go	`50.88% <35.71%> (-1.17%)`	⬇️
models/repo_watch.go	`65.11% <0%> (-3.49%)`	⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0820e0...8f297ca. Read the comment docs.

ngourdon · 2019-05-12T16:26:03Z

Merge to master.
The PR go-gitea/go-sdk#166 is no longer required thanks to #6905
Build is passing

lunny · 2019-07-08T02:19:45Z

Please resolve the conflicts

ngourdon · 2019-07-11T14:03:23Z

@lunny conflicts resolved

lunny · 2019-07-13T04:39:53Z

models/org_team.go

+// addAllRepositories adds all repositories to the team.
+// If the team already has some repositories they will be left unchanged.
+func (t *Team) addAllRepositories(e Engine) error {
+	err := e.Iterate(&Repository{OwnerID: t.OrgID}, func(i int, bean interface{}) error {


Why not just change includesAllRepository to true?

All repositories need to be added to the team because access rights management won't work without them.
It is the same behavior as for owners teams.

OK. And I think we should use a better method to batch insert a slice of team_repo.

Sure we can use a better method to batch insert a slice of team_repo but the method addRepository do a lot more than that.
imho I don't think the batch insert will be worth it compared to the whole processing.

Assume there are 1000 repositories on this organization. And the code here is not work with sqlite database.

It still return 500 on my local test.

I can't reproduce the issue. I must do it wrong.
I build with TAGS="bindata sqlite sqlite_unlock_notify" make clean generate build
I tested on Linux and Windows.
Do the UT pass on your local machine?
Can you please give me the steps which lead to the error 500?

That's what I compiled locally. I'm on macOS. Just grant team to all organization repositories.

The UT must fail, don't they?

Problematic in pgSQL as well (500). After some debugging I found hasTeamRepo get this error: lib/pq#635

models/org_team.go

routers/api/v1/convert/convert.go

davidsvantesson · 2019-09-01T19:32:19Z

I would like to have a warning when pressing 'Update Setting' if includes_all_repositories was changed from false to true. Something like "This will add access for the team access to all 1118 repositories in the organization" Ok/Cancel.
If you have really many repositories and someone do this change by mistake, it will take time to restore.

lafriks · 2019-09-30T20:20:45Z

Please resolve conflicts

davidsvantesson · 2019-10-05T12:11:55Z

@ngourdon doesn't seem to be active right now. Can I take over this (create a new PR)?

lunny · 2019-11-06T11:40:45Z

replaced by #8688

ngourdon added 4 commits April 28, 2019 17:11

Add field IsAllRepositories to team

0b8e90e

Add AllRepositories to team UI

b478a10

Manage team with access to all repositories

e5f6d9e

Add field IsAllRepositories to team API

7cca125

lafriks reviewed Apr 28, 2019

View reviewed changes

models/migrations/v85.go Outdated Show resolved Hide resolved

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 28, 2019

lafriks reviewed Apr 28, 2019

View reviewed changes

models/migrations/v85.go Outdated Show resolved Hide resolved

lafriks reviewed Apr 28, 2019

View reviewed changes

models/org_team.go Outdated Show resolved Hide resolved

lafriks added the type/enhancement An improvement of existing functionality label Apr 28, 2019

lafriks added this to the 1.9.0 milestone Apr 28, 2019

lafriks added the type/changelog Adds the changelog for a new Gitea version label Apr 28, 2019

lunny requested changes Apr 30, 2019

View reviewed changes

models/org_team.go Show resolved Hide resolved

ngourdon added 3 commits April 30, 2019 19:23

put backticks around table/column names

a02aa18

rename IsAllRepositories to IncludesAllRepositories

8216a2a

do not reload slice if already loaded

f698385

ngourdon changed the title ~~Add team option to grant rights for all organization repositories~~ [WIP] Add team option to grant rights for all organization repositories May 7, 2019

ngourdon added 4 commits May 8, 2019 16:16

add repo to teams with access to all repositories when changing repo …

0496588

…owner

improve tests for teams with access to all repositories

c097a29

Merge branch 'master'

3a3ccf8

Merge branch 'master'

5fa75d4

ngourdon changed the title ~~[WIP] Add team option to grant rights for all organization repositories~~ Add team option to grant rights for all organization repositories May 9, 2019

Merge branch 'master' into fix-6409

d262016

techknowlogick modified the milestones: 1.9.0, 1.10.0 Jun 25, 2019

Merge branch 'master' into fix-6409

8f297ca

lunny reviewed Jul 13, 2019

View reviewed changes

models/org_team.go Show resolved Hide resolved

lunny reviewed Jul 13, 2019

View reviewed changes

routers/api/v1/convert/convert.go Show resolved Hide resolved

davidsvantesson mentioned this pull request Sep 1, 2019

[WIP] Add team option to automatically add new organization repos #8048

Closed

4 tasks

davidsvantesson mentioned this pull request Sep 1, 2019

Add teams to repo on collaboration page. #8045

Merged

davidsvantesson mentioned this pull request Sep 30, 2019

Team permission to create repository in organization #8312

Merged

lunny modified the milestones: 1.10.0, 1.11.0 Oct 4, 2019

davidsvantesson mentioned this pull request Oct 25, 2019

Add team option to grant rights for all organization repositories #8688

Merged

lunny closed this Nov 6, 2019

lunny removed this from the 1.11.0 milestone Nov 6, 2019

go-gitea locked and limited conversation to collaborators Nov 24, 2020

delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add team option to grant rights for all organization repositories #6791

Add team option to grant rights for all organization repositories #6791

ngourdon commented Apr 28, 2019

ngourdon commented May 9, 2019

lafriks commented May 9, 2019

ngourdon commented May 9, 2019

codecov-io commented May 12, 2019 •

edited

Loading

ngourdon commented May 12, 2019

lunny commented Jul 8, 2019

ngourdon commented Jul 11, 2019

lunny Jul 13, 2019

ngourdon Jul 13, 2019

lunny Jul 13, 2019

ngourdon Jul 13, 2019 •

edited

Loading

lunny Jul 14, 2019

lunny Jul 18, 2019

ngourdon Jul 18, 2019

lunny Jul 18, 2019

ngourdon Jul 18, 2019

davidsvantesson Oct 3, 2019

davidsvantesson commented Sep 1, 2019

lafriks commented Sep 30, 2019

davidsvantesson commented Oct 5, 2019

lunny commented Nov 6, 2019

Add team option to grant rights for all organization repositories #6791

Add team option to grant rights for all organization repositories #6791

Conversation

ngourdon commented Apr 28, 2019

ngourdon commented May 9, 2019

lafriks commented May 9, 2019

ngourdon commented May 9, 2019

codecov-io commented May 12, 2019 • edited Loading

Codecov Report

ngourdon commented May 12, 2019

lunny commented Jul 8, 2019

ngourdon commented Jul 11, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ngourdon Jul 13, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davidsvantesson commented Sep 1, 2019

lafriks commented Sep 30, 2019

davidsvantesson commented Oct 5, 2019

lunny commented Nov 6, 2019

codecov-io commented May 12, 2019 •

edited

Loading

ngourdon Jul 13, 2019 •

edited

Loading