Fixes #5960 - Adds API Endpoint for Repo Edit #7006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/gitea into fix-5960-edit-repo-api-endpoint
lunny
added
modifies/api
lafriks
reviewed
May 21, 2019
GiteaBot
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## master #7006 +/- ##
========================================
Coverage ? 41.6%
========================================
Files ? 443
Lines ? 60137
Branches ? 0
========================================
Hits ? 25021
Misses ? 31842
Partials ? 3274
Continue to review full report at Codecov.
|
zeripath
reviewed
May 22, 2019
zeripath
reviewed
May 22, 2019
|
Made a change to some of the body fields of the JSON for the PATCH endpoint (enable_wiki, enable_issues are has_wiki and has_issues like Github as well as like the repo response object), as well as added these editable fields to the Repository response object so the API can know what was originally set and what is set now. |
|
Something you've added has caused a deadlock in TestAPIRepoMigrate /go/src/code.gitea.io/gitea/integrations/api_repo_test.go:299 The relevant bit of the stack trace appears to be here: |
…/gitea into fix-5960-edit-repo-api-endpoint
lunny
requested changes
May 26, 2019
lunny
reviewed
May 29, 2019
lafriks
approved these changes
May 30, 2019
zeripath
approved these changes
May 30, 2019
lunny
approved these changes
May 30, 2019
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
* Feature - go-gitea#5960 - API Endpoint for Repo Editing * Revert from merge * Adds integration testing * Updates to integration tests * Revert changes * Update year in file header * Misspell fix * XORM = test * XORM = test * revert XORM = file * Makes RepoUnit.ID be pk and autoincr * Fix to units * revert header * Remove print statement * Adds other responses * Improves swagger for creating repo * Fixes import order * Better Unit Type does not exist error * Adds editable repo properties to the response repo structure * Fix to api_repo_edit_test.go * Fixes repo test * Changes per review * Fixes typo and standardizes comments in the EditRepoOption struct for swagger * Fixes typo and standardizes comments in the EditRepoOption struct for swagger * Actually can unarchive through the API * Unlike delete, user doesn't have to be the owner of the org, just admin to the repo * Fix to swagger comments for field name change * Update to swagger docs * Update swagger * Changes allow_pull_requests to has_pull_requests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #5960
This is to make it so Gitea has the repo Edit API endpoint just like Github. See https://developer.github.com/v3/repos/#edit for what this was to mimic
For the JSON body object, this uses the same names as Github in the JSON binding (one exception: used "webpage" instead of "homepage" since that is what we say in the repo settings page), but uses Gitea property names of the Repository object.
This should be usable for user who has admin privileges to a repo.
All options in the payload for this endpoint are optional, including name (Github says it is required but even for their API it is not and doesn't make sense to be unless your changing the repo name).