Fix content download and /verify LFS handler expecting wrong content-type #7015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes go-gitea#6960 According to [spec][1], /verify requests must have `Accept: application/vnd.git-lfs+json` Previous code works because `git-lfs` also [violates spec and doesn't send any Accept header at all][2] For other clients that DO set `Accept: application/vnd.git-lfs+json`, addition of `Accept: application/vnd.git-lfs` either forces them to violate the spec or is ignored, depending on order in what they create header list. [1]: https://github.com/git-lfs/git-lfs/blob/master/docs/api/basic-transfers.md#verification [2]: git-lfs/git-lfs#3662
Codecov Report
@@ Coverage Diff @@
## master #7015 +/- ##
=========================================
Coverage ? 41.49%
=========================================
Files ? 441
Lines ? 59504
Branches ? 0
=========================================
Hits ? 24689
Misses ? 31590
Partials ? 3225
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
zeripath
changed the title
|
OK @slonopotamus I've closed my PR in preference to yours - the only difference I can see is that you're demanding that the lfs-client has to send to /verify with the correct content-type. (BTW We do use different urls for verify and download. What don't use is different urls for download content vs. meta that is determined by content-type.) |
zeripath
approved these changes
May 23, 2019
GiteaBot
added
lgtm/need 1
|
Btw, git-lfs agreed that it is a bug on their side that they don't set Accept header for verify url and are going to fix it: git-lfs/git-lfs#3663 |
lafriks
approved these changes
May 24, 2019
GiteaBot
added
lgtm/done
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
Fixes go-gitea#6960 According to [spec][1], /verify requests must have `Accept: application/vnd.git-lfs+json` Previous code works because `git-lfs` also [violates spec and doesn't send any Accept header at all][2] For other clients that DO set `Accept: application/vnd.git-lfs+json`, addition of `Accept: application/vnd.git-lfs` either forces them to violate the spec or is ignored, depending on order in what they create header list. [1]: https://github.com/git-lfs/git-lfs/blob/master/docs/api/basic-transfers.md#verification [2]: git-lfs/git-lfs#3662
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6960
According to spec, /verify requests must have
Accept: application/vnd.git-lfs+jsonPrevious code works because
git-lfsalso violates spec and doesn't send any Accept header at allFor other clients that DO set
Accept: application/vnd.git-lfs+json, addition ofAccept: application/vnd.git-lfseither forces them to violate the spec or is ignored, depending on order in what they create header list.