Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong init dependency on markup extensions #7038

Merged
merged 4 commits into from May 25, 2019

Conversation

6 participants
@lunny
Copy link
Member

commented May 25, 2019

This will fix the bug that markdown parser has been initialized before customerize markdown extensions load.

@lunny lunny added this to the 1.9.0 milestone May 25, 2019

@lafriks

This comment has been minimized.

Copy link
Member

commented May 25, 2019

Tests fail

lunny added some commits May 25, 2019

@lunny lunny force-pushed the lunny:lunny/fix_markup_init branch from b7fc649 to e04058c May 25, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 25, 2019

Codecov Report

Merging #7038 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7038      +/-   ##
==========================================
- Coverage   41.49%   41.46%   -0.04%     
==========================================
  Files         441      442       +1     
  Lines       59526    59597      +71     
==========================================
+ Hits        24700    24709       +9     
- Misses      31597    31658      +61     
- Partials     3229     3230       +1
Impacted Files Coverage Δ
modules/markup/markup.go 81.15% <100%> (+2.12%) ⬆️
routers/init.go 68.49% <100%> (+0.43%) ⬆️
modules/log/colors_router.go 83.33% <0%> (-4.17%) ⬇️
models/repo_list.go 72.08% <0%> (-1.02%) ⬇️
modules/markup/external/external.go 1.58% <0%> (ø)
modules/log/event.go 65.98% <0%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c432d2...e7f27cf. Read the comment docs.

@lunny

This comment has been minimized.

Copy link
Member Author

commented May 25, 2019

@lafriks fixed

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels May 25, 2019

zeripath and others added some commits May 25, 2019

@zeripath zeripath changed the title Fix wrong init dependency on markup extersions Fix wrong init dependency on markup extensions May 25, 2019

@zeripath zeripath merged commit 355ab0c into go-gitea:master May 25, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@lunny lunny deleted the lunny:lunny/fix_markup_init branch May 26, 2019

@lafriks

This comment has been minimized.

Copy link
Member

commented May 29, 2019

@lunny please send backport

lunny added a commit to lunny/gitea that referenced this pull request May 29, 2019

Fix wrong init dependency on markup extensions (go-gitea#7038)
* fix wrong init dependency on markup extensions

techknowlogick added a commit that referenced this pull request May 29, 2019

Fix wrong init dependency on markup extensions (#7038) (#7074)
* fix wrong init dependency on markup extensions

jeffliu27 added a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019

Fix wrong init dependency on markup extensions (go-gitea#7038)
* fix wrong init dependency on markup extensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.