Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possbile mysql invalid connnection error #7051

Merged
merged 1 commit into from May 26, 2019

Conversation

@lunny
Copy link
Member

commented May 26, 2019

Should fix #5612 and #6804 , this may not be a gitea's bug but dependent packages.

@lunny lunny added the kind/bug label May 26, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 26, 2019

Codecov Report

Merging #7051 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7051      +/-   ##
==========================================
+ Coverage   41.44%   41.45%   +0.01%     
==========================================
  Files         442      442              
  Lines       59604    59608       +4     
==========================================
+ Hits        24702    24713      +11     
+ Misses      31672    31665       -7     
  Partials     3230     3230
Impacted Files Coverage Δ
models/models.go 57.5% <100%> (+0.72%) ⬆️
routers/repo/view.go 43.03% <0%> (+1.01%) ⬆️
modules/log/event.go 65.98% <0%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 063fa99...8bd1083. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels May 26, 2019

@lafriks lafriks added this to the 1.9.0 milestone May 26, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels May 26, 2019

@lafriks lafriks merged commit c2f3938 into go-gitea:master May 26, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@lafriks

This comment has been minimized.

Copy link
Member

commented May 26, 2019

Please send backport

@lunny lunny deleted the lunny:lunny/mysql_connection branch May 29, 2019

lunny added a commit that referenced this pull request May 29, 2019

zeripath added a commit that referenced this pull request May 29, 2019

@zeripath zeripath referenced this pull request Jun 1, 2019
2 of 7 tasks complete

jeffliu27 added a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.