Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle early git version's lack of get-url #7065

Conversation

@zeripath
Copy link
Contributor

commented May 28, 2019

Old versions of git do not have git remote get-url in which case we can use git config --get remote.<name>.url - however, please note that this is not a complete replacement for this as it will not handle insteadOf configuration. I do not think it is reasonable however to completely replicate this functionality and if users require that they should upgrade.

Fix #6930

@zeripath zeripath added this to the 1.9.0 milestone May 28, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 28, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@d01e728). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7065   +/-   ##
=========================================
  Coverage          ?   41.42%           
=========================================
  Files             ?      442           
  Lines             ?    59701           
  Branches          ?        0           
=========================================
  Hits              ?    24731           
  Misses            ?    31733           
  Partials          ?     3237
Impacted Files Coverage Δ
models/repo_mirror.go 22.91% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d01e728...83ab6a7. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels May 28, 2019

@lunny

lunny approved these changes May 29, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels May 29, 2019

@zeripath zeripath merged commit 57b2ce0 into go-gitea:master May 29, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details
@lafriks

This comment has been minimized.

Copy link
Member

commented May 29, 2019

Please backporr

techknowlogick added a commit that referenced this pull request May 29, 2019

@zeripath zeripath deleted the zeripath:handle-old-git-for-git-remote-get-url-fixes-#6930 branch Jun 13, 2019

jeffliu27 added a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.