Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle early git version's lack of get-url #7065

Conversation

zeripath
Copy link
Contributor

Old versions of git do not have git remote get-url in which case we can use git config --get remote.<name>.url - however, please note that this is not a complete replacement for this as it will not handle insteadOf configuration. I do not think it is reasonable however to completely replicate this functionality and if users require that they should upgrade.

Fix #6930

@zeripath zeripath added backport/v1.8 issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself labels May 28, 2019
@zeripath zeripath added this to the 1.9.0 milestone May 28, 2019
@codecov-io
Copy link

codecov-io commented May 28, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@d01e728). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7065   +/-   ##
=========================================
  Coverage          ?   41.42%           
=========================================
  Files             ?      442           
  Lines             ?    59701           
  Branches          ?        0           
=========================================
  Hits              ?    24731           
  Misses            ?    31733           
  Partials          ?     3237
Impacted Files Coverage Δ
models/repo_mirror.go 22.91% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d01e728...83ab6a7. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 28, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 28, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 29, 2019
@zeripath zeripath merged commit 57b2ce0 into go-gitea:master May 29, 2019
@lafriks
Copy link
Member

lafriks commented May 29, 2019

Please backporr

@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label May 29, 2019
@zeripath zeripath deleted the handle-old-git-for-git-remote-get-url-fixes-#6930 branch June 13, 2019 14:17
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Required git version bump to 2.7.0 since v1.8.0
6 participants