Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow archived repos to be (un)starred and (un)watched #7163

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Allow archived repos to be (un)starred and (un)watched #7163

merged 1 commit into from
Jun 10, 2019

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Jun 9, 2019

Fixes #7158

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 9, 2019
@adelowo adelowo changed the title Allow archived repos can be (un)starred and (un)watched Allow archived repos to be (un)starred and (un)watched Jun 9, 2019
@codecov-io
Copy link

Codecov Report

Merging #7163 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7163      +/-   ##
==========================================
- Coverage   41.76%   41.75%   -0.01%     
==========================================
  Files         448      448              
  Lines       61061    61061              
==========================================
- Hits        25503    25499       -4     
- Misses      32245    32250       +5     
+ Partials     3313     3312       -1
Impacted Files Coverage Δ
routers/routes/routes.go 82.85% <100%> (ø) ⬆️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
models/repo_list.go 72.08% <0%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8de0b0a...e05f450. Read the comment docs.

@lunny lunny added the type/bug label Jun 10, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 10, 2019
@lunny lunny added this to the 1.9.0 milestone Jun 10, 2019
@lunny lunny merged commit 3e05661 into go-gitea:master Jun 10, 2019
@lunny
Copy link
Member

lunny commented Jun 10, 2019

Please send back port to v1.8

@adelowo adelowo deleted the stars_on_archived_repo branch June 10, 2019 07:14
adelowo added a commit to adelowo/gitea that referenced this pull request Jun 10, 2019
@adelowo
archived repos can be starred and watched (go-gitea#7163)
b994ded
@adelowo adelowo mentioned this pull request Jun 10, 2019
Merged
techknowlogick pushed a commit that referenced this pull request Jun 10, 2019
@adelowo @techknowlogick
archived repos can be starred and watched (#7163) (#7168)
5e97b2d
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Jun 10, 2019
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@adelowo @jeffliu27
archived repos can be starred and watched (go-gitea#7163)
1dfd47c
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Archived repository should be allowed star but not return 404.
5 participants
@adelowo @codecov-io @lunny @techknowlogick @GiteaBot