Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If milestone id is zero don't get it from database #7169

Merged
merged 2 commits into from Jun 10, 2019

Conversation

@lunny
Copy link
Member

commented Jun 10, 2019

As title.

@lunny lunny added this to the 1.9.0 milestone Jun 10, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jun 10, 2019

Codecov Report

Merging #7169 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7169      +/-   ##
==========================================
- Coverage   41.75%   41.73%   -0.03%     
==========================================
  Files         449      449              
  Lines       61111    61112       +1     
==========================================
- Hits        25515    25503      -12     
- Misses      32281    32297      +16     
+ Partials     3315     3312       -3
Impacted Files Coverage Δ
routers/repo/issue.go 35.6% <0%> (-0.28%) ⬇️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
models/issue_milestone.go 57.69% <0%> (-1.48%) ⬇️
models/error.go 32.08% <0%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d93e623...26674f2. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels Jun 10, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Jun 10, 2019

@lunny lunny merged commit 7162fbf into go-gitea:master Jun 10, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@lunny lunny deleted the lunny:lunny/fix_milestone_issue branch Jun 10, 2019

@lunny lunny added the backport/done label Jun 10, 2019

jeffliu27 added a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.