Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-git to v4.12.0 #7249

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Update go-git to v4.12.0 #7249

merged 1 commit into from
Jun 19, 2019

Conversation

techknowlogick
Copy link
Member

fixes #7248

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 18, 2019
@codecov-io
Copy link

Codecov Report

Merging #7249 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7249      +/-   ##
==========================================
- Coverage   40.98%   40.98%   -0.01%     
==========================================
  Files         462      462              
  Lines       62585    62585              
==========================================
- Hits        25653    25648       -5     
- Misses      33571    33575       +4     
- Partials     3361     3362       +1
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_list.go 72.08% <0%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b209531...d60fd7b. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 19, 2019
@lunny lunny merged commit 33ad554 into go-gitea:master Jun 19, 2019
@techknowlogick techknowlogick added this to the 1.9.0 milestone Jun 19, 2019
@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Jun 19, 2019
@techknowlogick techknowlogick deleted the update-go-git branch June 19, 2019 02:15
@lunny
Copy link
Member

lunny commented Jun 19, 2019

@filipnavara As my simple local test with gitlab-ce, gitea's homepage load time always 4000ms ~ 5000ms before merging this PR or not. It should have an improvement on performance but not very obvious.

@zeripath
Copy link
Contributor

I think we're going to have to implement commit-graphs and bloom filters.

@filipnavara
Copy link
Contributor

I will send PR for loading commit-graphs, the modifications are quite small now that most of the API was upstreamed. I don't know what is the best place to generate them though. As far as bloom filters go I have an experimental implementation that looked really promising in my local test but it is not very polished.

@zeripath
Copy link
Contributor

I think as a start it might be sensible to tell git to use them if its version is young enough.

If the version is too old we'll probably have to update the graphs in post-receive.

We'll have to adjust any go-git based code to use information from the graphs too.

Does your implementation cope with looking in alternatives? We have moved to use shared in a lot of places and although the operations that we do in these tend not to do significant history walking they might still find some improvement.

@filipnavara
Copy link
Contributor

Does your implementation cope with looking in alternatives? We have moved to use shared in a lot of places and although the operations that we do in these tend not to do significant history walking they might still find some improvement.

Not at the moment, but it would be easy to implement. I only used it for the history queries used for directory listing so far. It may help in other places but I started with the biggest bottleneck in the first place.

jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update go-git dependency to get performance fixes
7 participants