Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pull view ui merge section #7335

Merged
merged 3 commits into from Jul 1, 2019

Conversation

5 participants
@lunny
Copy link
Member

commented Jul 1, 2019

Fix pull view ui when there is no status check. This is caused by #6845 .

Before

image

After

image

@lunny lunny added this to the 1.9.0 milestone Jul 1, 2019

@GiteaBot GiteaBot added the lgtm/need 1 label Jul 1, 2019

@GiteaBot GiteaBot added lgtm/done and removed lgtm/need 1 labels Jul 1, 2019

@techknowlogick

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

CI Fail

lunny added some commits Jul 1, 2019

@lunny lunny force-pushed the lunny:lunny/fix_pull_merge_section branch from b6fcb60 to 7cd0fbf Jul 1, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jul 1, 2019

Codecov Report

Merging #7335 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7335      +/-   ##
==========================================
- Coverage   41.29%   41.29%   -0.01%     
==========================================
  Files         466      466              
  Lines       63186    63186              
==========================================
- Hits        26095    26091       -4     
- Misses      33680    33685       +5     
+ Partials     3411     3410       -1
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️
routers/repo/view.go 42.23% <0%> (-1.02%) ⬇️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c6af9d...7cd0fbf. Read the comment docs.

@techknowlogick techknowlogick merged commit 1772c6b into go-gitea:master Jul 1, 2019

2 checks passed

approvals/lgtm this commit looks good
continuous-integration/drone/pr Build is passing
Details

@lunny lunny deleted the lunny:lunny/fix_pull_merge_section branch Jul 1, 2019

stertingen added a commit to stertingen/gitea that referenced this pull request Jul 2, 2019

fix pull view ui merge section (go-gitea#7335)
* fix pull view ui merge section

* fix tests

* fix tests

jeffliu27 added a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019

fix pull view ui merge section (go-gitea#7335)
* fix pull view ui merge section

* fix tests

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.