show special repo state if avatar is set

[Cherrg]

add icons like on repo list

suggested in, fix #7384

#Images

[jolheiser]

Two things I'm wondering...

1. Should it always be on the right side, rather than only if there's an avatar? Then it would be consistent.
   a. Alternatively, should the icons just always show up on the left, next to the avatar if it exists?

2. An icon should show regardless of whether it's private or not, similar to how it would look with no avatar. At least in my opinion.

Suggested change

	{{if and .RelAvatarLink .IsPrivate}}<i class="text gold octicon octicon-lock"></i>{{end}}
	{{if not .RelAvatarLink}}<i class="text gold octicon octicon-{{if .IsPrivate}}lock{{else if .IsMirror}}repo-clone{{else if .IsFork}}repo-forked{{else}}repo{{end}}"></i>{{end}}

[Cherrg]

My opinion

• icon position:
  • I would place the small ones always on right side. So text will not jump around if there is something special on repository (special: private,mirror,fork,archived)
• I would only show the small icons, when it is hidden by avatar.
  When no avatar is set then there would be a second icon with the same information
• furthermore i would't show a symbol on right side if it is a normal repository
  • so you see with a short glance if it is a normal repo or not (i know, with no avatar the normal repo icon is shown, but the size is bigger.)
• you're right i missed the other special icons, thanks for the hint. But the first condition in your proposal isn't correct. Your proposal would only be rendered if avatar is not set.
  -> I will add the other icons there

[jolheiser]

Ah, good catch on my suggestion.

[codecov-io]

Codecov Report

Merging #7387 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7387      +/-   ##
==========================================
- Coverage   41.19%   41.18%   -0.01%     
==========================================
  Files         469      469              
  Lines       63536    63536              
==========================================
- Hits        26172    26167       -5     
- Misses      33944    33948       +4     
- Partials     3420     3421       +1

Impacted Files	Coverage Δ
modules/process/manager.go	76.81% <0%> (-4.35%)	⬇️
models/repo_list.go	72.08% <0%> (-1.02%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0622e83...9d390e5. Read the comment docs.

[lunny]

When REPOSITORY_AVATAR_FALLBACK=none then it's not consist between repository list and repository view.

[Cherrg]

@lunny

• are configuration/setting flags accessible on templates, or do I need to set some key in ctx.Data manually?
• suggestion: - if REPOSITORY_AVATAR_FALLBACK=none
  • hide left icon
  • show right one (if special case)

[mrsdizzie]

• are configuration/setting flags accessible on templates, or do I need to set some key in ctx.Data manually?

You could add a helper to this file if needed:

https://github.com/go-gitea/gitea/blob/master/modules/templates/helper.go

[lunny]

How about always put lock icon right of the repositories' name on repository view page?

[lafriks]

I agree with @lunny about placing it always right as it is easier and more consistent

[silverwind]

Would also suggest increasing the size of right-side icons a bit and try to vertically center them with the text.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.