Add units concept for modulable functions of a repository #742
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| package migrations | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "time" | ||
|
|
||
| "code.gitea.io/gitea/modules/markdown" | ||
|
|
||
| "github.com/go-xorm/xorm" | ||
| ) | ||
|
|
||
| // RepoUnit describes all units of a repository | ||
| type RepoUnit struct { | ||
| ID int64 | ||
| RepoID int64 `xorm:"INDEX(s)"` | ||
| Type int `xorm:"INDEX(s)"` | ||
| Index int | ||
| Config map[string]string `xorm:"JSON"` | ||
| CreatedUnix int64 `xorm:"INDEX CREATED"` | ||
| Created time.Time `xorm:"-"` | ||
| } | ||
|
|
||
| // Enumerate all the unit types | ||
| const ( | ||
| UnitTypeCode = iota + 1 // 1 code | ||
| UnitTypeIssues // 2 issues | ||
| UnitTypePRs // 3 PRs | ||
| UnitTypeCommits // 4 Commits | ||
| UnitTypeReleases // 5 Releases | ||
| UnitTypeWiki // 6 Wiki | ||
| UnitTypeSettings // 7 Settings | ||
| UnitTypeExternalWiki // 8 ExternalWiki | ||
| UnitTypeExternalTracker // 9 ExternalTracker | ||
| ) | ||
|
|
||
| // Repo describes a repository | ||
| type Repo struct { | ||
| ID int64 | ||
| EnableWiki, EnableExternalWiki, EnableIssues, EnableExternalTracker, EnablePulls bool | ||
| ExternalWikiURL, ExternalTrackerURL, ExternalTrackerFormat, ExternalTrackerStyle string | ||
| } | ||
|
|
||
| func addUnitsToTables(x *xorm.Engine) error { | ||
| var repos []Repo | ||
| err := x.Table("repository").Find(&repos) | ||
| if err != nil { | ||
| return fmt.Errorf("Query repositories: %v", err) | ||
| } | ||
|
|
||
| sess := x.NewSession() | ||
| defer sess.Close() | ||
|
|
||
| if err := sess.Begin(); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| var repoUnit RepoUnit | ||
| if err := sess.CreateTable(&repoUnit); err != nil { | ||
| return fmt.Errorf("CreateTable RepoUnit: %v", err) | ||
| } | ||
|
|
||
| if err := sess.CreateUniques(&repoUnit); err != nil { | ||
| return fmt.Errorf("CreateUniques RepoUnit: %v", err) | ||
| } | ||
|
|
||
| if err := sess.CreateIndexes(&repoUnit); err != nil { | ||
| return fmt.Errorf("CreateIndexes RepoUnit: %v", err) | ||
| } | ||
|
|
||
| for _, repo := range repos { | ||
| for i := 1; i <= 9; i++ { | ||
| if (i == UnitTypeWiki || i == UnitTypeExternalWiki) && !repo.EnableWiki { | ||
| continue | ||
| } | ||
| if i == UnitTypeExternalWiki && !repo.EnableExternalWiki { | ||
| continue | ||
| } | ||
| if i == UnitTypePRs && !repo.EnablePulls { | ||
| continue | ||
| } | ||
| if (i == UnitTypeIssues || i == UnitTypeExternalTracker) && !repo.EnableIssues { | ||
| continue | ||
| } | ||
| if i == UnitTypeExternalTracker && !repo.EnableExternalTracker { | ||
| continue | ||
| } | ||
|
|
||
| var config = make(map[string]string) | ||
| switch i { | ||
| case UnitTypeExternalTracker: | ||
| config["ExternalTrackerURL"] = repo.ExternalTrackerURL | ||
| config["ExternalTrackerFormat"] = repo.ExternalTrackerFormat | ||
| if len(repo.ExternalTrackerStyle) == 0 { | ||
| repo.ExternalTrackerStyle = markdown.IssueNameStyleNumeric | ||
| } | ||
| config["ExternalTrackerStyle"] = repo.ExternalTrackerStyle | ||
| case UnitTypeExternalWiki: | ||
| config["ExternalWikiURL"] = repo.ExternalWikiURL | ||
| } | ||
|
|
||
| if _, err = sess.Insert(&RepoUnit{ | ||
| RepoID: repo.ID, | ||
| Type: i, | ||
| Index: i, | ||
| Config: config, | ||
| }); err != nil { | ||
| return fmt.Errorf("Insert repo unit: %v", err) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if err := sess.Commit(); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to have the keys of
RepoUnit.Configbe an enum type instead of string literals? I see two advantages to using an enum:"ExternalTrackerFormat", and the compiler won't tell you if you do.RepoUnit.Configfield is converted to JSON to store in the database, the generated JSON object will have shorter fields, and thus will use up less disk space.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.