Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid make-generate downloading packages from the internet #8008

Merged
merged 2 commits into from Aug 28, 2019
Merged

Avoid make-generate downloading packages from the internet #8008

merged 2 commits into from Aug 28, 2019

Conversation

typeless
Copy link
Contributor

Fixes #7997

@typeless
Copy link
Contributor Author

typeless commented Aug 28, 2019 •
edited

~~ Also, I assume the PACKAGES and SOURCES env variables don't need to be configurable. ~~
Skip the related changes.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 28, 2019
@typeless typeless changed the title Fix Makefile using non-vendor packages WIP: Fix make-generate using non-vendor packages Aug 28, 2019
@lunny
Copy link
Member

lunny commented Aug 28, 2019 •
edited

I think we have -mod=vendor on https://github.com/go-gitea/gitea/blob/master/Makefile#L100 . But it seems this is still necessary.

@typeless
Copy link
Contributor Author

@lunny yes, but after trying to make generate by myself, I found it does downloads from the internet. The root cause is actually go list ./....

What baffles me right now is that I cannot reproduce the CI error at my local machine.

@typeless typeless force-pushed the fix-using-non-vendor-packages branch from ad1ee1e to 65d675d Compare August 28, 2019 06:17
@typeless
Copy link
Contributor Author

We still have other dependencies which require downloads such as the swagger tool.
The latest version (go-swagger/go-swagger#1681) of go-swagger has supported modules. Hopefully, we can remove the GO111MODULE=off workaround soon.

@sapk
Copy link
Member

sapk commented Aug 28, 2019

@typeless and current go-swagger version require to be in GOPATH which hold us to move to a real mod workflow.

@sapk sapk mentioned this pull request Aug 28, 2019
Merged
@typeless typeless changed the title WIP: Fix make-generate using non-vendor packages Fix make-generate using non-vendor packages Aug 28, 2019
@typeless typeless changed the title Fix make-generate using non-vendor packages Avoid make-generate downloading from the internet Aug 28, 2019
@typeless typeless changed the title Avoid make-generate downloading from the internet Avoid make-generate downloading packages from the internet Aug 28, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 28, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 28, 2019
@codecov-io
Copy link

Codecov Report

Merging #8008 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8008      +/-   ##
==========================================
- Coverage    41.6%   41.59%   -0.01%     
==========================================
  Files         479      479              
  Lines       64106    64106              
==========================================
- Hits        26669    26665       -4     
- Misses      33979    33984       +5     
+ Partials     3458     3457       -1
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️
models/repo_list.go 73.17% <0%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1338825...5ed3a3a. Read the comment docs.

@sapk sapk merged commit dd3ba9b into go-gitea:master Aug 28, 2019
@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Aug 29, 2019
@typeless typeless deleted the fix-using-non-vendor-packages branch September 3, 2019 09:32
@markVnl markVnl mentioned this pull request Sep 16, 2019
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@sapk sapk sapk approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not build anymore since version 1.9.0
6 participants
@typeless @lunny @sapk @codecov-io @mrsdizzie @GiteaBot