-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid including "num_issues" and "num_closed_issues" multiple times #8337
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8337 +/- ##
==========================================
+ Coverage 41.62% 41.63% +<.01%
==========================================
Files 495 495
Lines 65523 65524 +1
==========================================
+ Hits 27274 27280 +6
+ Misses 34730 34725 -5
Partials 3519 3519
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this should be taken into account by xorm, but it doesn't hurt handling it here as well.
This should be fixed upstream in xorm (cc: @lunny ) as with this it will be harder to keep list updated if new columns are added to that table etc |
I have sent go-xorm/xorm#1446, |
@lunny we've recently adopted the tagged xorm |
@guillep2k I merged #8317 as it still clean the double dependency and I think it is better to do it step by step. Just need to re-do the same steps like any update deps 😄
|
@sapk It makes sense. Let's wait for xorm to be tagged, then. Please you make the PR when that's ready. |
I have tag xorm v0.7.9 |
@sapk Do you want to take care of the PR? |
@guillep2k please go if you have time. I will maybe have time tonight but don't wait on me if you can do it. |
@sapk Oh, I thought you wanted to make a single PR containing both changes. I can do the Gitea part of course. |
Fixed upstream in xorm, and with PR #8355, closing this pr. |
Only update columns that have not been specified already in the query.
Fixes issue #8336.