Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kanban board #8346

Merged
merged 379 commits into from Aug 17, 2020
Merged

Kanban board #8346

merged 379 commits into from Aug 17, 2020

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Oct 1, 2019

Fixes #3476

  • Move Issues between Boards
  • add Project to current Issue
  • view project
  • create a project
  • create Issue during viewing project
  • select project during create Issue
  • add Board to an existing Project
  • delete Board from a project
  • rename Board title
  • Individual boards
  • Organization boards
  • Repository boards

Definitely another PR:

  • Location of cards in the project board. Right now, cards location in a board cannot be persisted - i.e move card X above card Y in the same board.

@rudineirk UI suggestion ( from #3476 (comment) ) was used.

Screen Shot 2020-03-17 at 23 31 20

Screen Shot 2020-03-17 at 23 31 41

Screen Shot 2020-03-17 at 23 31 51

image

image

Copy link
Member

@sapk sapk left a comment

Just quickly looking at it, it seems good overall. I have found some quirks that must come from the fact that some code in this PR as some history.

models/issue.go Outdated Show resolved Hide resolved
models/issue.go Outdated Show resolved Hide resolved
models/migrations/migrations.go Outdated Show resolved Hide resolved
models/migrations/v92.go Outdated Show resolved Hide resolved
models/migrations/v96.go Outdated Show resolved Hide resolved
models/migrations/v93.go Outdated Show resolved Hide resolved
models/migrations/v96.go Outdated Show resolved Hide resolved
templates/base/footer.tmpl Outdated Show resolved Hide resolved
@sapk
Copy link
Member

@sapk sapk commented Oct 3, 2019

The lint tool make golangci-lint suggest some changes that need to be taken in account (unsed, duplicate, ...).

models/migrations/migrations.go Outdated Show resolved Hide resolved
@lafriks
Copy link
Member

@lafriks lafriks commented Oct 3, 2019

As I understand projects are per-repository not per-organization, right?

@adelowo
Copy link
Member Author

@adelowo adelowo commented Oct 3, 2019

Yes

@lafriks
Copy link
Member

@lafriks lafriks commented Oct 3, 2019

How hard would it be to change that to be organization wide like github?

@adelowo
Copy link
Member Author

@adelowo adelowo commented Oct 3, 2019

Should not be too complicated. But GitHub has both repo and organization wide projects.

@gary-kim
Copy link
Member

@gary-kim gary-kim commented Oct 3, 2019

Having both organization and repository projects would be really nice. Thank you @adelowo

@andrewgdunn
Copy link

@andrewgdunn andrewgdunn commented Oct 4, 2019

I'd vote for Individual, Organizational, and Repository level projects/workboards.

  • For personal it would be nice to be able to allow viewing of the workboard (e.g. let others know what you're planning to work on)

If anyone wants to swoop in and assist on UX/UI work related to what @adelowo is doing I'd be happy to directly fund that effort.

@sapk sapk added this to the 1.11.0 milestone Oct 4, 2019
public/less/_repository.less Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@gsantner
Copy link

@gsantner gsantner commented Nov 8, 2019

just my 2cents:
why keep merging back and forth and having one big PR instead of "base" kanban PR & implementation and do then another PR(s)?
guess smaller PR is also a lot easier&faster to review.
(I mean, thats by some way suggested already by the description, but still there are many points open for the suggested initial base version.)

@adelowo
Copy link
Member Author

@adelowo adelowo commented Nov 8, 2019

It will be squashed eventually. Secondly, these features are tightly coupled.

@lunny
Copy link
Member

@lunny lunny commented Nov 16, 2019

Please resolve the conflicts.

@adelowo
Copy link
Member Author

@adelowo adelowo commented Nov 20, 2019

Done @lunny

models/migrations/v104.go Outdated Show resolved Hide resolved
@techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Dec 12, 2019

@adelowo is this still WIP? Can I remove the label?

Edit: It looks like most of the checkmarks you have listed above are done, and I think the rest could be implemented in a later PR.

@adelowo
Copy link
Member Author

@adelowo adelowo commented Dec 12, 2019

@techknowlogick working on this during the weekend. Can strike off a few more by then and
the rest can come in another PR

@lunny
Copy link
Member

@lunny lunny commented Dec 16, 2019

@adelowo I suggest to move this to v1.12 since we need more time to review it. It's a big feature.

@adelowo
Copy link
Member Author

@adelowo adelowo commented Dec 16, 2019

@lunny Makes sense

@lunny lunny removed this from the 1.11.0 milestone Dec 16, 2019
@lunny lunny added this to the 1.12.0 milestone Dec 16, 2019
templates/repo/issue/view_content/comments.tmpl Outdated Show resolved Hide resolved
@6543
Copy link
Member

@6543 6543 commented Dec 17, 2019

for confilct resolve:

  • Comment Type 25 is now Used so 26 is the next free one
  • public/js / public/css can be removed completly
  • migration only nee higher number
  • modules/setting/repository.go: simple confilct happend by end of list issue of git
  • routers/repo/issue.go same thing as last one

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Aug 11, 2020

Codecov Report

Merging #8346 into master will decrease coverage by 0.19%.
The diff coverage is 27.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8346      +/-   ##
==========================================
- Coverage   43.73%   43.54%   -0.20%     
==========================================
  Files         631      637       +6     
  Lines       69873    70821     +948     
==========================================
+ Hits        30561    30836     +275     
- Misses      34352    34982     +630     
- Partials     4960     5003      +43     
Impacted Files Coverage Δ
models/error.go 34.81% <0.00%> (-0.61%) ⬇️
models/migrations/migrations.go 4.66% <ø> (ø)
models/migrations/v146.go 0.00% <0.00%> (ø)
modules/auth/repo_form.go 42.34% <ø> (ø)
modules/structs/repo.go 54.54% <ø> (ø)
routers/api/v1/repo/repo.go 62.15% <0.00%> (-1.41%) ⬇️
routers/repo/milestone.go 0.00% <0.00%> (ø)
routers/repo/setting.go 14.85% <0.00%> (-0.18%) ⬇️
routers/user/home.go 60.88% <ø> (ø)
routers/user/profile.go 48.46% <0.00%> (-2.34%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f50364a...a48f839. Read the comment docs.

@mooror
Copy link

@mooror mooror commented Aug 12, 2020

Huge thank you to everyone who has worked on this feature. This is going to be a game changer for the company I work for. Looking forward to it.

Long live Gitea!
Benjamin

@vtolstov
Copy link

@vtolstov vtolstov commented Aug 13, 2020

i'm use gitea from the beginning, and like this feature. why it not merged yet? i think that if it will be merged as soon as possible we can have many testers and contributors, for now this pr looks like really huge and not so many people can provide some useful help

@jaqra
Copy link
Member

@jaqra jaqra commented Aug 13, 2020

@vtolstov waiting for @lafriks 's review, then this will be merged if no any problem

@techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Aug 17, 2020

🚀

@techknowlogick techknowlogick merged commit 4027c5d into go-gitea:master Aug 17, 2020
1 of 2 checks passed
@a1012112796
Copy link
Member

@a1012112796 a1012112796 commented Aug 17, 2020

Suggest add some screenshots to the REAME.md file.

@adelowo adelowo deleted the kanban_board branch Aug 17, 2020
@patcito patcito mentioned this pull request Aug 17, 2020
3 tasks
@patcito
Copy link
Contributor

@patcito patcito commented Aug 17, 2020

As promised, here is my PR that builds on @adelowo work #12506 Let me know what you think.

@philiplb
Copy link

@philiplb philiplb commented Aug 17, 2020

Nice! Awesome work! <3

SuccessGo pushed a commit to SuccessOpen/gitea that referenced this issue Aug 20, 2020
* Make tabs smaller

Fomantic's tabs are excessively wide and with another tab added on the
repo tabbar (go-gitea#8346) it would break
the layout on the english language.

Globally reduce tab bar padding to around half of the previous values.

* disable no-duplicate-selectors linter rule

* more tab bar tweaks

* more tweaks

* merge rules and nesting

* remove arc-green weird hover color

* few more arc-green tweaks

* restore to 12px

* tweaks

* use half width height padding

* final tweak

* 10px

* remove min-height

* 11px

* remve new-menu background on light theme too

* background fixes for new-menu

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
SuccessGo pushed a commit to SuccessOpen/gitea that referenced this issue Aug 20, 2020
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: jaqra <48099350+jaqra@users.noreply.github.com>
Co-authored-by: Kerry <flatline-studios@users.noreply.github.com>
Co-authored-by: Jaqra <jaqra@hotmail.com>
Co-authored-by: Kyle Evans <kevans91@users.noreply.github.com>
Co-authored-by: Tsakiridis Ilias <TsakiDev@users.noreply.github.com>
Co-authored-by: Ilias Tsakiridis <ilias.tsakiridis@outlook.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
zeripath added a commit to zeripath/gitea that referenced this issue Aug 29, 2020
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: jaqra <48099350+jaqra@users.noreply.github.com>
Co-authored-by: Kerry <flatline-studios@users.noreply.github.com>
Co-authored-by: Jaqra <jaqra@hotmail.com>
Co-authored-by: Kyle Evans <kevans91@users.noreply.github.com>
Co-authored-by: Tsakiridis Ilias <TsakiDev@users.noreply.github.com>
Co-authored-by: Ilias Tsakiridis <ilias.tsakiridis@outlook.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@TheTechRobo
Copy link

@TheTechRobo TheTechRobo commented Sep 3, 2020

in migration there is no selection for project board migration

@6543
Copy link
Member

@6543 6543 commented Sep 3, 2020

@TheTechRobo because project migration is not supported jet

@Extarys
Copy link

@Extarys Extarys commented Sep 3, 2020

  • You should add this feature in the comparison table 😄
  • Any ETA when this will be part of a release? Not to rush or anything, I'm not familiar with the release cycle and methods of Gitea. (I'll use Nextcloud Deck on my personal instance in the mean time as I'm just planning the project right now)

Fun sidenote: I'm working on a new project for fun at home and I was checking out nextcloud Deck and Notes, but for my use (only this project) I find it too bloated and since I'll be writing some code, Gitea came to mind.

I'm currently checking out Taiga in a docker container, but of course I would prefer everything to be at the same place (ie: with the code and the issues on Gitea) I kind of like their point system to prioritize (which is not a priority here)
image

Quite funny this issue was merged recently! 🙏

Another sidenote: I've been seeing lots of open source projects belonging to small companies that got bought by big tech giants and closing their OSS or not contributing to the Open-source dataset, etc and it was refreshing browsing Gitea repo today. Good job to everyone for releasing so many versions and committing so many new features! ❤️

@patrickdevivo Awesome PR! Would it be a good idea to have an option to tag the issue automatically once it was added to the kanban? [ie: kanban/low priority] I believe it would help when browsing the issue tracker to know which one is already planned/tagged or just read.

@6543
Copy link
Member

@6543 6543 commented Sep 4, 2020

@Extarys @TheTechRobo please open a NEW issue to discuss such things on

all you post on this Merged pull will fall out of our minds and in the end will be ignored
there is no good in commenting at a closed pull -> you should just reference them :)

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.