[WIP] Improve dashboard repo search #872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreynering
added
topic/ui
bkcsoft
reviewed
Feb 9, 2017
public/js/index.js
Outdated
| @@ -1474,16 +1475,45 @@ function selectRange($list, $select, $from) { | |||
| changeHash('#' + $select.attr('rel')); | |||
| } | |||
|
|
|||
| $(function () { | |||
| if ($('.user.signin').length > 0) return; | |||
| $('form').areYouSure(); | |||
|
|
||
| searchRepos: function() { | ||
| var self = this; | ||
| $.getJSON('/api/v1/repos/search?q=' + self.searchQuery, function(result) { |
There was a problem hiding this comment.
And all of sudden I feel the urge to write an API-client for javascript (I hate hard-coded URLs 😆 )
There was a problem hiding this comment.
This will not work if gitea is reached on a subfolder
| </li> | ||
| {{end}} | ||
| <ul class="repo-owner-name-list"> | ||
| <li v-for="repo in repos" :class="{'private': repo.private}"> |
There was a problem hiding this comment.
This means no more server-side rendering right? Is that a good idea?
| @@ -54,9 +52,9 @@ | |||
| {{.i18n.Tr "home.collaborative_repos"}} | |||
| </h4> | |||
| <div class="ui attached table segment"> | |||
| <ul id="collaborative-repo-list" class="search-list"> | |||
| <ul id="collaborative-repo-list"> | |||
| {{range .CollaborativeRepos}} | |||
There was a problem hiding this comment.
No search on collaborative repos?
|
any update? |
tboerger
added
the
lgtm/need 2
|
@lunny Not yet. I'll have to review if the API is already complete to finalize this. |
|
@andreynering I suggest move this to v1.3 |
|
@lunny Done. Sorry for the delay. |
|
@andreynering conflicts. |
|
Closed in favor of #1652 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP.
Followup of #773. This PR makes possible to search all repos, not just the 15 listed.