Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto merge pull requests when all checks succeeded via API #9307

Merged
merged 307 commits into from
May 7, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
307 commits
Select commit Hold shift + click to select a range
341aef2
Fix indention
kolaente Jul 19, 2020
10d2dd6
Add option to merge a pr right now without waiting for the checks to …
kolaente Jul 19, 2020
6044bc6
Fix lint
kolaente Jul 19, 2020
452310d
Add scheduled pr merge to tables used for testing
kolaente Jul 19, 2020
72ae3de
Merge branch 'master' into feature/auto-merge
kolaente Jul 22, 2020
7b14e16
Add status param to make GetPullRequestByHeadBranch reusable
kolaente Jul 22, 2020
9b99253
Move "Merge now" to a seperate button to make the ui clearer
kolaente Jul 22, 2020
df39bcc
Update models/scheduled_pull_request_merge.go
kolaente Jul 22, 2020
5f5c84c
Merge branch 'master' into feature/auto-merge
kolaente Jul 22, 2020
2c3e2a6
Update web_src/js/index.js
kolaente Jul 23, 2020
3321ad0
Merge branch 'master' into feature/auto-merge
kolaente Jul 23, 2020
eb63b61
Update web_src/js/index.js
kolaente Jul 23, 2020
e86a3ab
Merge branch 'master' into feature/auto-merge
kolaente Jul 27, 2020
38278bb
Merge branch 'master' into feature/auto-merge
kolaente Dec 15, 2020
2dbd642
Merge remote-tracking branch 'origin/feature/auto-merge' into feature…
kolaente Dec 15, 2020
308d423
Re-add migration after merge
kolaente Dec 15, 2020
81efbaf
Fix frontend lint
kolaente Dec 15, 2020
1d54f4c
Fix version compare
kolaente Dec 15, 2020
d4337b2
Add vendored dependencies
kolaente Dec 15, 2020
0c9a741
Add basic tets
kolaente Dec 15, 2020
407bdab
Make sure the api route is capable of scheduling PRs for merging
kolaente Dec 15, 2020
2ac0136
Merge branch 'master' into feature/auto-merge
kolaente Dec 15, 2020
5f2d076
Fix comparing version
kolaente Dec 15, 2020
1109de2
Merge branch 'feature/auto-merge' of github.com:kolaente/gitea into f…
kolaente Dec 15, 2020
4cd7ba0
make vendor
kolaente Dec 15, 2020
11cc7a0
Merge branch 'master' into feature/auto-merge
6543 Feb 12, 2021
f2c2547
adopt refactor
6543 Feb 12, 2021
7316455
apply suggestion: User -> Doer
6543 Feb 12, 2021
01cc62f
init var once
6543 Feb 12, 2021
5fe32f1
Fix Test
6543 Feb 12, 2021
c55d67a
Merge branch 'master' into feature/auto-merge
kolaente Feb 13, 2021
6cfe63b
Merge branch 'master' into feature/auto-merge
6543 Feb 19, 2021
79667e9
Merge branch 'master' into feature/auto-merge
kolaente Feb 22, 2021
9808a8b
Merge branch 'master' into feature/auto-merge
kolaente Feb 27, 2021
8ffc978
Merge branch 'master' into feature/auto-merge
6543 Mar 1, 2021
5c99f8b
Merge branch 'master' into feature/auto-merge
6543 Apr 8, 2021
bbe51fb
Update templates/repo/issue/view_content/comments.tmpl
6543 Apr 8, 2021
4d1b77b
Merge branch 'master' into feature/auto-merge
6543 Apr 8, 2021
a21bc92
adopt
6543 Apr 8, 2021
fd290d1
Merge branch 'master' into feature/auto-merge
6543 Apr 8, 2021
673b657
Merge branch 'master' into feature/auto-merge
6543 Apr 10, 2021
f30ab00
Merge branch 'master' into feature/auto-merge
6543 Apr 10, 2021
a1dab29
nits
6543 Apr 10, 2021
f92385f
next
6543 Apr 10, 2021
738f66a
code format
6543 Apr 10, 2021
fe86285
lint
6543 Apr 10, 2021
b3f90f2
Merge branch 'master' into feature/auto-merge
6543 Apr 11, 2021
ac6c002
use same name schema; rm CreateUnScheduledPRToAutoMergeComment
6543 Apr 11, 2021
7745e74
API: can not create schedule twice
6543 Apr 11, 2021
b271c15
Add TestGetBranchNamesForSha
6543 Apr 11, 2021
b1a7f4d
Merge branch 'master' into feature/auto-merge
6543 Apr 11, 2021
0927f33
nits
6543 Apr 11, 2021
7029905
new go routine for each pull to merge
6543 Apr 11, 2021
003a0cd
Merge branch 'master' into feature/auto-merge
6543 Apr 13, 2021
d75691d
Merge branch 'master' into feature/auto-merge
6543 Apr 15, 2021
d1c1f31
Merge branch 'master' into feature/auto-merge
kolaente Apr 26, 2021
6f00624
Merge branch 'main' into feature/auto-merge
kolaente May 8, 2021
c317e30
Merge branch 'main' into feature/auto-merge
6543 May 12, 2021
68475a3
Update models/pull.go
kolaente May 13, 2021
1f0231f
Update models/scheduled_pull_request_merge.go
kolaente May 13, 2021
f0a4720
Merge branch 'main' into feature/auto-merge
6543 May 16, 2021
8432030
fix & add renaming sugestions
6543 May 16, 2021
55ac505
Update services/automerge/pull_auto_merge.go
6543 May 16, 2021
745b784
Merge branch 'main' into feature/auto-merge
kolaente May 17, 2021
efa97ce
Merge branch 'master' into feature/auto-merge
6543 Jul 3, 2021
38c9538
Merge branch 'main' into feature/auto-merge
6543 Jul 7, 2021
2a8d230
Merge branch 'master' into feature/auto-merge
6543 Jul 18, 2021
848990c
fix conflict relicts
6543 Jul 18, 2021
ab20836
Merge branch 'master' into feature/auto-merge
6543 Sep 27, 2021
4e52813
apply latest refactors
6543 Sep 27, 2021
6f1bee0
Merge branch 'main' into feature/auto-merge
kolaente Oct 15, 2021
cf0aea9
fix: migration after merge
kolaente Oct 15, 2021
f6c0cad
Merge branch 'main' into feature/auto-merge
6543 Oct 15, 2021
0b89b6c
Update models/error.go
kolaente Oct 16, 2021
0b6724b
Update options/locale/locale_en-US.ini
kolaente Oct 16, 2021
6d2bb4e
Update options/locale/locale_en-US.ini
kolaente Oct 16, 2021
5abb112
Merge branch 'master' into feature/auto-merge
6543 Oct 16, 2021
8522e4c
Merge branch 'main' into feature/auto-merge
6543 Oct 17, 2021
4100e19
Merge branch 'master' into feature/auto-merge
6543 Mar 29, 2022
635abdd
adapt latest refactors
6543 Mar 29, 2022
af22476
fix test
6543 Mar 29, 2022
68c0bd7
Merge branch 'master' into feature/auto-merge
6543 Mar 29, 2022
dfc8a7a
use more context
6543 Mar 29, 2022
397bb67
skip potential edgecases
6543 Mar 29, 2022
c0fbcaa
document func usage
6543 Mar 29, 2022
529cf03
Merge branch 'master' into feature/auto-merge
6543 Mar 29, 2022
f63742e
GetBranchNamesForSha() -> GetRefsBySha()
6543 Mar 29, 2022
28295f7
start refactoring
6543 Mar 29, 2022
af9a58b
Merge branch 'master' into feature/auto-merge
6543 Mar 29, 2022
b2930ec
ajust to new changes
6543 Mar 29, 2022
47c815d
nit
6543 Mar 29, 2022
dcbd06d
docu nit
6543 Mar 29, 2022
9b9bd7b
Merge branch 'master' into feature/auto-merge
6543 Mar 30, 2022
03eb945
the great check move
6543 Mar 30, 2022
6a9dae2
Merge branch 'master' into feature/auto-merge
6543 Mar 30, 2022
d8e0686
move checks for branchprotection into own package
6543 Mar 30, 2022
6f15ec8
resolve todo now ...
6543 Mar 30, 2022
f17abd1
move & rename
6543 Mar 30, 2022
2a66e96
unexport if posible
6543 Mar 30, 2022
d2023d8
fix
6543 Mar 31, 2022
8292182
check if merge is allowed before merge on scheduled pull
6543 Mar 31, 2022
c8496aa
debugg
6543 Mar 31, 2022
80b63ee
Merge branch 'master' into feature/auto-merge
6543 Mar 31, 2022
a1073bc
Merge branch 'main' into single-place-to-enforce-protected-branch-rules
6543 Mar 31, 2022
52cb7c4
wording
6543 Mar 31, 2022
f4b4a0b
Merge branch 'main' into single-place-to-enforce-protected-branch-rules
6543 Mar 31, 2022
c0e932a
improve SetDefaults & nits
6543 Mar 31, 2022
6959e27
NotAllowedToMerge -> DisallowedToMerge
6543 Mar 31, 2022
4775c3a
fix test
6543 Mar 31, 2022
8c6a54f
Merge branch 'main' into single-place-to-enforce-protected-branch-rules
6543 Mar 31, 2022
943d1f2
merge files
6543 Mar 31, 2022
f7b89a5
Merge branch 'master' into single-place-to-enforce-protected-branch-r…
6543 Mar 31, 2022
19200ac
Merge branch 'master' into feature/auto-merge
6543 Mar 31, 2022
5d3f346
Merge branch 'single-place-to-enforce-protected-branch-rules' into fe…
6543 Mar 31, 2022
120d84d
use package "errors"
6543 Mar 31, 2022
d0a2312
merge files
6543 Mar 31, 2022
ce534e0
Merge branch 'single-place-to-enforce-protected-branch-rules' into fe…
6543 Mar 31, 2022
4c2460f
Merge branch 'master' into feature/auto-merge
6543 Mar 31, 2022
f187990
add string names
6543 Mar 31, 2022
e99481c
other implementation for gogit
6543 Mar 31, 2022
6a10944
Merge branch 'master' into feature/auto-merge
6543 Apr 1, 2022
ff93d83
Merge branch 'master' into feature/auto-merge
6543 Apr 2, 2022
3baf1d0
Merge branch 'main' into feature/auto-merge
6543 Apr 21, 2022
4f1344c
Merge branch 'master' into feature/auto-merge
6543 Apr 26, 2022
03cbafd
adapt refactor
6543 Apr 26, 2022
261b407
more context for models/pull.go
6543 Apr 26, 2022
90f96cf
GetUserRepoPermission use context
6543 Apr 26, 2022
505c2cd
Merge branch 'master' into feature/auto-merge
6543 Apr 26, 2022
1583951
more ctx
6543 Apr 26, 2022
ec11287
Merge branch 'master' into refactor-from-9307
6543 Apr 26, 2022
832d7d6
use context for loading pull head/base-repo
6543 Apr 26, 2022
abf5067
more ctx
6543 Apr 26, 2022
fea87e6
more ctx
6543 Apr 26, 2022
e3e3741
models.LoadIssueCtx()
6543 Apr 26, 2022
1013108
models.LoadIssueCtx()
6543 Apr 26, 2022
9088331
Handle pull_service.Merge in one DB transaction
6543 Apr 26, 2022
673a81a
add TODOs
6543 Apr 26, 2022
6765298
next
6543 Apr 26, 2022
82259d5
next
6543 Apr 26, 2022
0b2a290
next
6543 Apr 26, 2022
e283421
Merge branch 'master' into refactor-from-9307
6543 Apr 26, 2022
811e15a
more ctx
6543 Apr 26, 2022
bf432d8
more ctx
6543 Apr 26, 2022
fbb9f50
Merge branch 'main' into feature/auto-merge
6543 Apr 26, 2022
461bea5
Start refactoring structure of old pull code ...
6543 Apr 26, 2022
b226064
move code into new packages
6543 Apr 26, 2022
981cdde
shorter names ... and finish **restructure**
6543 Apr 26, 2022
0e56288
Update models/branches.go
6543 Apr 26, 2022
2d079ee
finish UpdateProtectBranch
6543 Apr 26, 2022
bc474bb
more and fix
6543 Apr 26, 2022
594517f
Merge branch 'refactor-from-9307' into feature/auto-merge
6543 Apr 26, 2022
7c411f4
update datum
6543 Apr 26, 2022
6d793b4
template: use "svg" helper
6543 Apr 26, 2022
fd58a14
rename prQueue 2 prPatchCheckerQueue
6543 Apr 26, 2022
cad41d2
handle automerge in queue
6543 Apr 26, 2022
fe4b06f
lock pull on git&db actions ...
6543 Apr 26, 2022
e6b7918
lock pull on git&db actions ...
6543 Apr 26, 2022
29319c4
add TODO notes
6543 Apr 26, 2022
524ece7
Merge branch 'pull_service-lock-per-pull' into feature/auto-merge
6543 Apr 27, 2022
a4d5f48
Merge branch 'main' into refactor-from-9307
6543 Apr 27, 2022
72ad384
Merge branch 'master' into refactor-from-9307
6543 Apr 27, 2022
4e74172
the regex
6543 Apr 27, 2022
61786f8
transaction in tests
6543 Apr 27, 2022
266f4b3
GetRepositoryByIDCtx
6543 Apr 27, 2022
20d00b8
Merge branch 'master' into feature/auto-merge
6543 Apr 27, 2022
76f0501
Merge branch 'refactor-from-9307' into feature/auto-merge
6543 Apr 27, 2022
b422328
shorter table name and lint fix
6543 Apr 27, 2022
cdc8706
Merge branch 'main' into refactor-from-9307
6543 Apr 28, 2022
1eb7812
Merge branch 'master' into refactor-from-9307
6543 Apr 28, 2022
ef4fcbe
close transaction bevore notify
6543 Apr 28, 2022
c856a2e
Merge branch 'refactor-from-9307' into feature/auto-merge
6543 Apr 28, 2022
6c9ff86
Merge branch 'master' into feature/auto-merge
6543 Apr 28, 2022
545d33e
Merge branch 'master' into feature/auto-merge
6543 Apr 28, 2022
ddf1157
Update models/pull.go
6543 Apr 28, 2022
35b3071
Merge branch 'master' into feature/auto-merge
6543 Apr 29, 2022
b5b8ca3
Merge branch 'main' into feature/auto-merge
6543 May 1, 2022
02abd0c
next
6543 May 1, 2022
10b277b
CheckPullMergable check all branch protections!
6543 May 1, 2022
9330ec4
Merge branch 'main' into feature/auto-merge
6543 May 1, 2022
d9c07c9
Update routers/web/repo/pull.go
6543 May 1, 2022
22f7a4b
CheckPullMergable check all branch protections!
6543 May 1, 2022
2003602
Revert "PullService lock via pullID (#19520)" (for now...)
6543 May 1, 2022
8411cc9
Merge branch 'CheckPullMergable_check_all_branch_protections' into fe…
6543 May 1, 2022
ceda060
Merge branch 'master' into feature/auto-merge
6543 May 2, 2022
faa06f1
Update services/pull/check.go
6543 May 2, 2022
b09b46b
Use for a repo action one database transaction
6543 May 2, 2022
04207b9
Apply suggestions from code review
6543 May 2, 2022
a6a335a
Merge branch 'main' into more-context-again
6543 May 2, 2022
cd48d31
Apply suggestions from code review
6543 May 3, 2022
54e849a
Update services/issue/status.go
6543 May 3, 2022
48b76f9
Merge branch 'master' into more-context-again
6543 May 3, 2022
443168a
Update services/issue/status.go
6543 May 3, 2022
419f064
use db.WithTx()
6543 May 3, 2022
0312d2f
gofmt
6543 May 3, 2022
427ba1e
Merge branch 'master' into more-context-again
6543 May 3, 2022
cdb4683
Merge branch 'master' into feature/auto-merge
6543 May 3, 2022
9cc0d28
Merge branch 'more-context-again' into feature/auto-merge
6543 May 3, 2022
7538993
make pr.GetDefaultMergeMessage() context aware
6543 May 3, 2022
ca8c1f1
make MergePullRequestForm.SetDefaults context aware
6543 May 3, 2022
e188963
use db.WithTx()
6543 May 3, 2022
3d3b847
pull.SetMerged only with context
6543 May 3, 2022
5d0a243
fix deadlock in `test-sqlite\#TestAPIBranchProtection`
6543 May 3, 2022
7741935
dont forget templates
6543 May 3, 2022
244f3f2
db.WithTx allow to set the parentCtx
6543 May 3, 2022
95df0f2
handle db transaction in service packages but not router
6543 May 3, 2022
58a7322
issue_service.ChangeStatus just had caused another deadlock :/
6543 May 3, 2022
4e099bd
if we merge a pull in one database transaktion, we get a lock, becaus…
6543 May 3, 2022
9813c63
Merge branch 'more-context-again' into feature/auto-merge
6543 May 3, 2022
d127b81
Merge branch 'master' into feature/auto-merge
6543 May 3, 2022
6d60e05
ajust to current master
6543 May 3, 2022
d3cc762
Apply suggestions from code review
6543 May 3, 2022
6e30456
dont open db transaction in router
6543 May 3, 2022
b0b8ed6
make generate-swagger
6543 May 3, 2022
713796e
one _success less
6543 May 3, 2022
1db379f
wording nit
6543 May 3, 2022
8bb0bd6
rm
6543 May 3, 2022
27ce2b0
adapt
6543 May 3, 2022
a47cd88
Merge branch 'main' into feature/auto-merge
6543 May 3, 2022
7ce6963
remove not needed test files
6543 May 4, 2022
faef76e
rm less diff & use attr in JS
6543 May 4, 2022
7456862
...
6543 May 4, 2022
01cebae
Merge branch 'main' into feature/auto-merge
6543 May 4, 2022
3911dcf
Update services/repository/files/commit.go
6543 May 4, 2022
4c0a287
Merge branch 'main' into feature/auto-merge
6543 May 4, 2022
16c7bbb
Merge branch 'main' into feature/auto-merge
6543 May 4, 2022
6633101
Merge branch 'master' into feature/auto-merge
6543 May 5, 2022
07ebb0d
ajust db schema for PullAutoMerge
6543 May 5, 2022
6eec790
skip broken pull refs
6543 May 5, 2022
5cf709d
more context in error messages
6543 May 5, 2022
9f43fc9
remove webUI part for another pull
6543 May 5, 2022
6566141
remove more WebUI only parts
6543 May 5, 2022
93702a4
API: add CancleAutoMergePR
6543 May 5, 2022
89670eb
Apply suggestions from code review
6543 May 5, 2022
23e2b84
Merge branch 'main' into feature/auto-merge
6543 May 5, 2022
f5458d2
fix lint
6543 May 5, 2022
34d0600
Merge branch 'main' into feature/auto-merge
6543 May 5, 2022
e4922f7
Apply suggestions from code review
zeripath May 5, 2022
3fa4840
cancle -> cancel
6543 May 6, 2022
1e17e83
Merge branch 'main' into feature/auto-merge
6543 May 6, 2022
cd522b3
change queue identifyer
6543 May 6, 2022
a57444e
fix swagger
6543 May 6, 2022
4f97aa1
prevent nil issue
6543 May 6, 2022
e374f9f
Merge branch 'master' into feature/auto-merge
6543 May 7, 2022
ea5e940
fix and dont drop error
6543 May 7, 2022
8df24af
as per @zeripath
6543 May 7, 2022
bbbcf40
Update integrations/git_test.go
6543 May 7, 2022
2364692
Update integrations/git_test.go
6543 May 7, 2022
749df65
more declarative integration tests (dedup code)
6543 May 7, 2022
95052c9
use assert.False/True helper
6543 May 7, 2022
5fd0d6f
Merge branch 'main' into feature/auto-merge
6543 May 7, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions integrations/api_helper_for_declarative_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,37 @@ func doAPIManuallyMergePullRequest(ctx APITestContext, owner, repo, commitID str
}
}

func doAPIAutoMergePullRequest(ctx APITestContext, owner, repo string, index int64) func(*testing.T) {
return func(t *testing.T) {
urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/merge?token=%s",
owner, repo, index, ctx.Token)
req := NewRequestWithJSON(t, http.MethodPost, urlStr, &forms.MergePullRequestForm{
MergeMessageField: "doAPIMergePullRequest Merge",
Do: string(repo_model.MergeStyleMerge),
MergeWhenChecksSucceed: true,
})

if ctx.ExpectedCode != 0 {
ctx.Session.MakeRequest(t, req, ctx.ExpectedCode)
return
}
ctx.Session.MakeRequest(t, req, 200)
}
}

func doAPICancelAutoMergePullRequest(ctx APITestContext, owner, repo string, index int64) func(*testing.T) {
return func(t *testing.T) {
urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/merge?token=%s",
owner, repo, index, ctx.Token)
req := NewRequest(t, http.MethodDelete, urlStr)
if ctx.ExpectedCode != 0 {
ctx.Session.MakeRequest(t, req, ctx.ExpectedCode)
return
}
ctx.Session.MakeRequest(t, req, 204)
}
}

func doAPIGetBranch(ctx APITestContext, branch string, callback ...func(*testing.T, api.Branch)) func(*testing.T) {
return func(t *testing.T) {
req := NewRequestf(t, "GET", "/api/v1/repos/%s/%s/branches/%s?token=%s", ctx.Username, ctx.Reponame, branch, ctx.Token)
Expand Down
83 changes: 83 additions & 0 deletions integrations/git_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ func testGit(t *testing.T, u *url.URL) {

t.Run("CreateAgitFlowPull", doCreateAgitFlowPull(dstPath, &httpContext, "master", "test/head"))
t.Run("BranchProtectMerge", doBranchProtectPRMerge(&httpContext, dstPath))
t.Run("AutoMerge", doAutoPRMerge(&httpContext, dstPath))
t.Run("CreatePRAndSetManuallyMerged", doCreatePRAndSetManuallyMerged(httpContext, httpContext, dstPath, "master", "test-manually-merge"))
t.Run("MergeFork", func(t *testing.T) {
defer PrintCurrentTest(t)()
Expand Down Expand Up @@ -615,6 +616,88 @@ func doBranchDelete(ctx APITestContext, owner, repo, branch string) func(*testin
}
}

func doAutoPRMerge(baseCtx *APITestContext, dstPath string) func(t *testing.T) {
return func(t *testing.T) {
defer PrintCurrentTest(t)()

ctx := NewAPITestContext(t, baseCtx.Username, baseCtx.Reponame)

t.Run("CheckoutProtected", doGitCheckoutBranch(dstPath, "protected"))
t.Run("PullProtected", doGitPull(dstPath, "origin", "protected"))
t.Run("GenerateCommit", func(t *testing.T) {
_, err := generateCommitWithNewData(littleSize, dstPath, "user2@example.com", "User Two", "branch-data-file-")
assert.NoError(t, err)
})
t.Run("PushToUnprotectedBranch", doGitPushTestRepository(dstPath, "origin", "protected:unprotected3"))
var pr api.PullRequest
var err error
t.Run("CreatePullRequest", func(t *testing.T) {
pr, err = doAPICreatePullRequest(ctx, baseCtx.Username, baseCtx.Reponame, "protected", "unprotected3")(t)
assert.NoError(t, err)
})

// Request repository commits page
req := NewRequest(t, "GET", fmt.Sprintf("/%s/%s/pulls/%d/commits", baseCtx.Username, baseCtx.Reponame, pr.Index))
resp := ctx.Session.MakeRequest(t, req, http.StatusOK)
doc := NewHTMLParser(t, resp.Body)

// Get first commit URL
commitURL, exists := doc.doc.Find("#commits-table tbody tr td.sha a").Last().Attr("href")
assert.True(t, exists)
assert.NotEmpty(t, commitURL)

commitID := path.Base(commitURL)

// Call API to add Pending status for commit
t.Run("CreateStatus", doAPICreateCommitStatus(ctx, commitID, api.CommitStatusPending))

// Cancel not existing auto merge
ctx.ExpectedCode = http.StatusNotFound
t.Run("CancelAutoMergePR", doAPICancelAutoMergePullRequest(ctx, baseCtx.Username, baseCtx.Reponame, pr.Index))

// Add auto merge request
ctx.ExpectedCode = http.StatusCreated
t.Run("AutoMergePR", doAPIAutoMergePullRequest(ctx, baseCtx.Username, baseCtx.Reponame, pr.Index))

// Can not create schedule twice
6543 marked this conversation as resolved.
Show resolved Hide resolved
ctx.ExpectedCode = http.StatusConflict
t.Run("AutoMergePRTwice", doAPIAutoMergePullRequest(ctx, baseCtx.Username, baseCtx.Reponame, pr.Index))

// Cancel auto merge request
ctx.ExpectedCode = http.StatusNoContent
t.Run("CancelAutoMergePR", doAPICancelAutoMergePullRequest(ctx, baseCtx.Username, baseCtx.Reponame, pr.Index))

// Add auto merge request
ctx.ExpectedCode = http.StatusCreated
t.Run("AutoMergePR", doAPIAutoMergePullRequest(ctx, baseCtx.Username, baseCtx.Reponame, pr.Index))

// Check pr status
ctx.ExpectedCode = 0
pr, err = doAPIGetPullRequest(ctx, baseCtx.Username, baseCtx.Reponame, pr.Index)(t)
assert.NoError(t, err)
assert.False(t, pr.HasMerged)

// Call API to add Failure status for commit
t.Run("CreateStatus", doAPICreateCommitStatus(ctx, commitID, api.CommitStatusFailure))

// Check pr status
pr, err = doAPIGetPullRequest(ctx, baseCtx.Username, baseCtx.Reponame, pr.Index)(t)
assert.NoError(t, err)
assert.False(t, pr.HasMerged)

// Call API to add Success status for commit
t.Run("CreateStatus", doAPICreateCommitStatus(ctx, commitID, api.CommitStatusSuccess))

// wait to let gitea merge stuff
time.Sleep(time.Second)

// test pr status
pr, err = doAPIGetPullRequest(ctx, baseCtx.Username, baseCtx.Reponame, pr.Index)(t)
assert.NoError(t, err)
assert.True(t, pr.HasMerged)
}
}

func doCreateAgitFlowPull(dstPath string, ctx *APITestContext, baseBranch, headBranch string) func(t *testing.T) {
return func(t *testing.T) {
defer PrintCurrentTest(t)()
Expand Down
31 changes: 21 additions & 10 deletions integrations/pull_status_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,20 +63,13 @@ func TestPullCreate_CommitStatus(t *testing.T) {
api.CommitStatusWarning: "warning sign icon yellow",
}

testCtx := NewAPITestContext(t, "user1", "repo1")

// Update commit status, and check if icon is updated as well
for _, status := range statusList {

// Call API to add status for commit
token := getTokenForLoggedInUser(t, session)
req = NewRequestWithJSON(t, "POST", fmt.Sprintf("/api/v1/repos/user1/repo1/statuses/%s?token=%s", commitID, token),
api.CreateStatusOption{
State: status,
TargetURL: "http://test.ci/",
Description: "",
Context: "testci",
},
)
session.MakeRequest(t, req, http.StatusCreated)
t.Run("CreateStatus", doAPICreateCommitStatus(testCtx, commitID, status))

req = NewRequestf(t, "GET", "/user1/repo1/pulls/1/commits")
resp = session.MakeRequest(t, req, http.StatusOK)
Expand All @@ -94,6 +87,24 @@ func TestPullCreate_CommitStatus(t *testing.T) {
})
}

func doAPICreateCommitStatus(ctx APITestContext, commitID string, status api.CommitStatusState) func(*testing.T) {
return func(t *testing.T) {
req := NewRequestWithJSON(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/statuses/%s?token=%s", ctx.Username, ctx.Reponame, commitID, ctx.Token),
api.CreateStatusOption{
State: status,
TargetURL: "http://test.ci/",
Description: "",
Context: "testci",
},
)
if ctx.ExpectedCode != 0 {
ctx.Session.MakeRequest(t, req, ctx.ExpectedCode)
return
}
ctx.Session.MakeRequest(t, req, http.StatusCreated)
}
}

func TestPullCreate_EmptyChangesWithCommits(t *testing.T) {
onGiteaRun(t, func(t *testing.T, u *url.URL) {
session := loginUser(t, "user1")
Expand Down
12 changes: 1 addition & 11 deletions integrations/repo_commits_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ func doTestRepoCommitWithStatus(t *testing.T, state string, classes ...string) {
defer prepareTestEnv(t)()

session := loginUser(t, "user2")
token := getTokenForLoggedInUser(t, session)

// Request repository commits page
req := NewRequest(t, "GET", "/user2/repo1/commits/branch/master")
Expand All @@ -49,16 +48,7 @@ func doTestRepoCommitWithStatus(t *testing.T, state string, classes ...string) {
assert.NotEmpty(t, commitURL)

// Call API to add status for commit
req = NewRequestWithJSON(t, "POST", "/api/v1/repos/user2/repo1/statuses/"+path.Base(commitURL)+"?token="+token,
api.CreateStatusOption{
State: api.CommitStatusState(state),
TargetURL: "http://test.ci/",
Description: "",
Context: "testci",
},
)

resp = session.MakeRequest(t, req, http.StatusCreated)
t.Run("CreateStatus", doAPICreateCommitStatus(NewAPITestContext(t, "user2", "repo1"), path.Base(commitURL), api.CommitStatusState(state)))

req = NewRequest(t, "GET", "/user2/repo1/commits/branch/master")
resp = session.MakeRequest(t, req, http.StatusOK)
Expand Down
6 changes: 6 additions & 0 deletions models/issue_comment.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,10 @@ const (
CommentTypeDismissReview
// 33 Change issue ref
CommentTypeChangeIssueRef
// 34 pr was scheduled to auto merge when checks succeed
CommentTypePRScheduledToAutoMerge
// 35 pr was un scheduled to auto merge when checks succeed
CommentTypePRUnScheduledToAutoMerge
6543 marked this conversation as resolved.
Show resolved Hide resolved
)

var commentStrings = []string{
Expand Down Expand Up @@ -147,6 +151,8 @@ var commentStrings = []string{
"project_board",
"dismiss_review",
"change_issue_ref",
"pull_scheduled_merge",
"pull_cancel_scheduled_merge",
}

func (t CommentType) String() string {
Expand Down
2 changes: 2 additions & 0 deletions models/migrations/migrations.go
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,8 @@ var migrations = []Migration{
NewMigration("Add package tables", addPackageTables),
// v213 -> v214
NewMigration("Add allow edits from maintainers to PullRequest table", addAllowMaintainerEdit),
// v214 -> v215
NewMigration("Add auto merge table", addAutoMergeTable),
}

// GetCurrentDBVersion returns the current db version
Expand Down
23 changes: 23 additions & 0 deletions models/migrations/v214.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
// Copyright 2022 The Gitea Authors. All rights reserved.
// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.

package migrations

import (
"xorm.io/xorm"
)

func addAutoMergeTable(x *xorm.Engine) error {
type MergeStyle string
type PullAutoMerge struct {
ID int64 `xorm:"pk autoincr"`
PullID int64 `xorm:"UNIQUE"`
DoerID int64 `xorm:"NOT NULL"`
MergeStyle MergeStyle `xorm:"varchar(30)"`
Message string `xorm:"LONGTEXT"`
CreatedUnix int64 `xorm:"created"`
}

return x.Sync2(&PullAutoMerge{})
}
14 changes: 14 additions & 0 deletions models/pull.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ import (
"code.gitea.io/gitea/modules/setting"
"code.gitea.io/gitea/modules/timeutil"
"code.gitea.io/gitea/modules/util"

"xorm.io/builder"
)

// PullRequestType defines pull request type
Expand Down Expand Up @@ -675,6 +677,18 @@ func (pr *PullRequest) IsSameRepo() bool {
return pr.BaseRepoID == pr.HeadRepoID
}

// GetPullRequestsByHeadBranch returns all prs by head branch
// Since there could be multiple prs with the same head branch, this function returns a slice of prs
func GetPullRequestsByHeadBranch(ctx context.Context, headBranch string, headRepoID int64) ([]*PullRequest, error) {
6543 marked this conversation as resolved.
Show resolved Hide resolved
log.Trace("GetPullRequestsByHeadBranch: headBranch: '%s', headRepoID: '%d'", headBranch, headRepoID)
prs := make([]*PullRequest, 0, 2)
if err := db.GetEngine(ctx).Where(builder.Eq{"head_branch": headBranch, "head_repo_id": headRepoID}).
Find(&prs); err != nil {
return nil, err
}
return prs, nil
}

// GetBaseBranchHTMLURL returns the HTML URL of the base branch
func (pr *PullRequest) GetBaseBranchHTMLURL() string {
if err := pr.LoadBaseRepo(); err != nil {
Expand Down
Loading