Add units to team #947
Add units to team #947
Conversation
lunny
added
type/feature
|
This is done and could be reviewed. When add/edit a team on organization, you could chose which units could be organization's repositories operated on the by this team. For example, we can define |
tboerger
added
the
lgtm/need 2
| UnitTypeWiki, | ||
| UnitTypeSettings, | ||
| UnitTypeExternalWiki, | ||
| UnitTypeExternalTracker, |
There was a problem hiding this comment.
Do we really need External as a separate unit? Can we enable both internal wiki and external wiki at the same time? (same for Tracker)
| 4, | ||
| } | ||
|
|
||
| UnitWiki = Unit{ | ||
| UnitTypeWiki, | ||
| "repo.wiki", | ||
| "/wiki", | ||
| "repo.wiki_desc", | ||
| "repo.wiki.desc", | ||
| 5, | ||
| } | ||
|
|
||
| UnitExternalWiki = Unit{ | ||
| UnitTypeExternalWiki, |
| 1, | ||
| } | ||
|
|
||
| UnitExternalTracker = Unit{ | ||
| UnitTypeExternalTracker, | ||
| "repo.issues", | ||
| "repo.ext_issues", |
| } | ||
| } | ||
|
|
||
| ctx.Handle(404, "Home", fmt.Errorf(ctx.Tr("units.error.no_unit_allowed_repo"))) |
There was a problem hiding this comment.
Why are we leaking information that this repo exists but have nothing to show? IMO no valid Units should be the same as Private.
There was a problem hiding this comment.
The error message is only for log. The UI will only show 404.
| }, reqSignIn, context.RepoAssignment(), context.UnitTypes(), context.LoadRepoUnits(), context.CheckUnit(models.UnitTypeIssues)) | ||
|
|
||
| // Releases | ||
| m.Group("/:username/:reponame", func() { |
There was a problem hiding this comment.
Move this for easy add middleware contex.CheckUnit. Before this, releases URLs are put on many places.
|
LGTM |
tboerger
added
lgtm/need 1
lunny
force-pushed
the
lunny/team_units
branch
2 times, most recently
from
e2da2af
to
299b4e9
Compare
models/migrations/v32.go
Outdated
| return err | ||
| } | ||
|
|
||
| _, err = x.Where("1=1").Update(&Team{ |
There was a problem hiding this comment.
Not an expert in xorm but can't .Where("1=1") be removed ?
|
This need rebase. |
tboerger
added
lgtm/done
|
@sapk rebased |
|
I know this PR is closed, but I believe I found an issue that might be related. I think this PR modified a lot of routes related to releases, I wonder if that has anything to do with it... |
|
@kubatyszko could you post an issue to describe that? |
This PR allows you create one team who can only see issues or pull request or wikis.