Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove un-needed script import since #9554 #9694

Merged
merged 3 commits into from
Jan 10, 2020
Merged

Remove un-needed script import since #9554 #9694

merged 3 commits into from
Jan 10, 2020

Conversation

sapk
Copy link
Member

@sapk sapk commented Jan 10, 2020

Since the removal of the standalone preset in #9554 for swagger ui this import is not needed anymore.

@sapk sapk added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 10, 2020
@sapk sapk added this to the 1.12.0 milestone Jan 10, 2020
@sapk sapk added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 10, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 10, 2020
@codecov-io
Copy link

Codecov Report

Merging #9694 into master will increase coverage by 0.15%.
The diff coverage is 47.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9694      +/-   ##
==========================================
+ Coverage    42.1%   42.25%   +0.15%     
==========================================
  Files         584      589       +5     
  Lines       77485    77989     +504     
==========================================
+ Hits        32623    32956     +333     
- Misses      40850    40991     +141     
- Partials     4012     4042      +30
Impacted Files Coverage Δ
models/issue_watch.go 61.84% <ø> (ø) ⬆️
services/pull/patch.go 62.65% <ø> (ø) ⬆️
models/action.go 46.87% <ø> (-11.09%) ⬇️
models/wiki.go 100% <ø> (ø) ⬆️
modules/auth/repo_form.go 43.47% <ø> (ø) ⬆️
models/migrations/migrations.go 1.3% <ø> (ø) ⬆️
routers/admin/admin.go 11.24% <0%> (ø) ⬆️
models/branches.go 45.5% <0%> (ø) ⬆️
modules/webhook/discord.go 1.92% <0%> (ø) ⬆️
modules/repository/repo.go 26.28% <0%> (-7.27%) ⬇️
... and 122 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1fc218...7363d40. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 10, 2020
@techknowlogick
Copy link
Member

ping LG-TM

@techknowlogick techknowlogick merged commit e90e435 into go-gitea:master Jan 10, 2020
@sapk sapk deleted the unneeded-swagger-script branch January 10, 2020 20:46
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sapk @codecov-io @techknowlogick @6543 @jolheiser @GiteaBot @lunny