Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Webhook wechat #9746

Closed
wants to merge 12 commits into from
Closed

WIP: Webhook wechat #9746

wants to merge 12 commits into from

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 13, 2020

use #5252 as source ... rebase & apply patches & refacotr ...

credits to: @rocklau

PS: everybody is welcome to pick this PR up ...

@6543
Copy link
Member Author

6543 commented Jan 13, 2020

@rocklau may you have a look at? (can't test this [dont have a wechat jet])

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 13, 2020
@codecov-io
Copy link

codecov-io commented Jan 13, 2020

Codecov Report

Merging #9746 into master will decrease coverage by <.01%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9746      +/-   ##
==========================================
- Coverage   42.12%   42.12%   -0.01%     
==========================================
  Files         598      598              
  Lines       78584    78584              
==========================================
- Hits        33106    33104       -2     
- Misses      41427    41431       +4     
+ Partials     4051     4049       -2
Impacted Files Coverage Δ
models/issue_comment.go 46.4% <100%> (ø) ⬆️
routers/api/v1/repo/issue_comment.go 56.33% <75%> (ø) ⬆️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
modules/queue/workerpool.go 41.2% <0%> (-1.29%) ⬇️
services/pull/temp_repo.go 34.18% <0%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18befa3...1ce8ab1. Read the comment docs.

@rocklau
Copy link

rocklau commented Jan 14, 2020

Recommend integrate with this package.
https://github.com/xen0n/go-workwx

@stale
Copy link

stale bot commented Mar 14, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Mar 14, 2020
@6543
Copy link
Member Author

6543 commented Mar 15, 2020

no stalebot no ;)

@stale stale bot removed the issue/stale label Mar 15, 2020
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Mar 16, 2020
Copy link

@Zoranner Zoranner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2020

Codecov Report

Merging #9746 into master will decrease coverage by 0.17%.
The diff coverage is 2.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9746      +/-   ##
==========================================
- Coverage   43.09%   42.91%   -0.18%     
==========================================
  Files         658      659       +1     
  Lines       72454    72725     +271     
==========================================
- Hits        31221    31212       -9     
- Misses      36178    36455     +277     
- Partials     5055     5058       +3     
Impacted Files Coverage Δ
models/webhook.go 67.77% <0.00%> (-0.38%) ⬇️
modules/auth/repo_form.go 41.59% <0.00%> (-0.75%) ⬇️
modules/convert/convert.go 72.05% <0.00%> (-0.96%) ⬇️
modules/webhook/webhook.go 43.54% <0.00%> (-1.46%) ⬇️
modules/webhook/workwechat.go 0.00% <0.00%> (ø)
routers/repo/webhook.go 0.95% <0.00%> (-0.09%) ⬇️
routers/routes/routes.go 89.04% <100.00%> (+0.07%) ⬆️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/indexer/stats/db.go 43.47% <0.00%> (-17.40%) ⬇️
modules/indexer/stats/queue.go 64.70% <0.00%> (-11.77%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f215e01...51fca2c. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #9746 into master will decrease coverage by 0.22%.
The diff coverage is 2.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9746      +/-   ##
==========================================
- Coverage   42.60%   42.38%   -0.23%     
==========================================
  Files         673      674       +1     
  Lines       73862    74133     +271     
==========================================
- Hits        31470    31419      -51     
- Misses      37275    37625     +350     
+ Partials     5117     5089      -28     
Impacted Files Coverage Δ
models/webhook.go 67.77% <0.00%> (-0.38%) ⬇️
modules/auth/repo_form.go 41.59% <0.00%> (-0.75%) ⬇️
modules/convert/convert.go 72.05% <0.00%> (-0.96%) ⬇️
modules/webhook/webhook.go 43.54% <0.00%> (-1.46%) ⬇️
modules/webhook/workwechat.go 0.00% <0.00%> (ø)
routers/repo/webhook.go 0.95% <0.00%> (-0.09%) ⬇️
routers/routes/routes.go 89.15% <100.00%> (+0.07%) ⬆️
modules/notification/ui/ui.go 72.22% <0.00%> (-8.34%) ⬇️
models/issue_comment.go 46.40% <0.00%> (-7.05%) ⬇️
modules/notification/mail/mail.go 28.73% <0.00%> (-5.75%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f27849...7694c7d. Read the comment docs.

Copy link

@Zoranner Zoranner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lunny
Copy link
Member

lunny commented Dec 15, 2020

Since #12310 merge, this should be updated.

@delvh
Copy link
Member

delvh commented Jul 23, 2021

Is this not closed by #15910?

@6543
Copy link
Member Author

6543 commented Jul 23, 2021

Closed by #15910

@6543 6543 closed this Jul 23, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants