Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial imlementation of list repos (#3) #13

Open
wants to merge 3 commits into
base: master
from

Conversation

4 participants
@root360-AndreasUlm
Copy link
Contributor

commented Apr 15, 2019

  • implemented runRepos()
  • reimplemented issues.initCommand() as repos.initCommandLoginOnly() as repos command does not always need a valid repository argument.

Output:

$ go build && ./tea repos --login try
Name    Type/Mode       SSH-URL Owner
test-orga/test source  git@try.gitea.io:test-orga/test.git    test-user

Signed-off-by: Andreas Ulm andreas.ulm@root360.de

initial imlementation of list repos (#3)
Signed-off-by: Andreas Ulm <andreas.ulm@root360.de>
@techknowlogick
Copy link
Member

left a comment

Thanks for PR 😄 Just a few nits.

Show resolved Hide resolved cmd/repos.go Outdated
Show resolved Hide resolved cmd/repos.go Outdated
improved code style
Signed-off-by: Andreas Ulm <andreas.ulm@root360.de>
@lunny

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

I think noheader flag seems unnecessary. We always needs a header. But for format print on console, \t will not always available.

@root360-AndreasUlm

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

I think noheader flag seems unnecessary. We always needs a header.

@lunny I just added the option to allow further output usage without requiring something like | tail -n -1 | to exclude the header.

But for format print on console, \t will not always available.

I just copied the output format from pulls.runPulls().

removed header & changed delimiter to pipe
Signed-off-by: Andreas Ulm <andreas.ulm@root360.de>
@root360-AndreasUlm

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

@lunny removed header flag and changed delimiter to pipe.

When I'm done with the unified output ( https://github.com/root360-AndreasUlm/tea/tree/unified_output_function ) the output of this function will be changed again.

dimissing my review as requested changes have been made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.