v3.3/glfw: handle GLFW_NO_WINDOW_CONTEXT error #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GLFW_NO_WINDOW_CONTEXT error code happens when a window without a context is passed to a function that requires it to have one. This is deemed a programmer mistake, something that this Go package currently handles by loudly panicking so the mistake is fixed sooner. Apply the same treatment to this error, which was previously missed and resulted in a "please report this in the Go package issue tracker" message being printed alongside the panic. Fixes #389.
Jacalz
approved these changes
Jan 17, 2024
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GLFW_NO_WINDOW_CONTEXTerror code happens when a window without a context is passed to a function that requires it to have one. This is deemed a programmer mistake, something that this Go package currently handles by loudly panicking so the mistake is fixed sooner.Apply the same treatment to this error, which was previously missed and resulted in a "please report this in the Go package issue tracker" message being printed alongside the panic.
Fixes #389.